aegir test --ts -t browser seems to fail

[Gozala]

It appears that aegir test --ts -t browser fails with timeout where ageir test -t browser does not:

multiformats/js-multiaddr@5a4b2df

[jacobheun]

This also creates some blocking issues for running tests during release. ref multiformats/js-multiaddr#154

[hugomrdias]

why are you using --ts if multiaddr is not written in ts ?

[Gozala]

@hugomrdias here is the thread with the whole story
multiformats/js-multiaddr#131 (comment)

[hugomrdias]

the problem is mixing commonjs with ts, we only support full ts or full commonjs with jsdoc.
plus this file https://github.com/multiformats/js-multiaddr/blob/master/test/types.spec.ts is testing nothing

[hugomrdias]

testing types is done with aegir ts -p check which will be released soon

[Gozala]

Not sure I follow all this, but that file was added by multiformats/js-multiaddr#112 and from the pull it appears it was introduced to ensure exported types did type-check.

Maybe with aegir ts -p check we no longer need it, but I am not entirely sure. Even if things type check and we generate some types that does not mean that those types would come out the way we expect. That said maybe it is reasonable to assume that and not bother having tests for it.

[hugomrdias]

theres .d.ts tests (we can add support for that), but that is a separate thing.
we can't handle mixed projects with the current setup.
i will handle this in that repo and aegir itself.

[hugomrdias]

what we need in aegir is to not include .ts files in aegir test if --ts is not true