Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use custom .eslintrc with different rules for .js and .ts #141

Merged
merged 5 commits into from
Aug 10, 2020

Conversation

Gozala
Copy link
Contributor

@Gozala Gozala commented Aug 7, 2020

Attempt to fix #131 by doing following:

  1. Create local .eslintrc that uses different eslint configs from aegir based on file extension.
  2. Reformats .ts file to satisfy linter.
  3. Passes --ts when running test, but opts out of --ts when running browser tests to workaround aegir test --ts -t browser seems to fail ipfs/aegir#619

@Gozala
Copy link
Contributor Author

Gozala commented Aug 7, 2020

This is strange, seems to do the trick on my device

@Gozala Gozala changed the title fix: disable linter for types/types.spec.ts fix: use custom .eslintrc with different rules for .js and .ts Aug 7, 2020
Copy link
Contributor

@jacobheun jacobheun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jacobheun jacobheun merged commit df4c822 into dependabot/npm_and_yarn/aegir-25.0.0 Aug 10, 2020
@jacobheun jacobheun deleted the gozala/aegir-25.0.0 branch August 10, 2020 13:29
jacobheun pushed a commit that referenced this pull request Aug 10, 2020
* chore(deps-dev): bump aegir from 22.1.0 to 25.0.0

Bumps [aegir](https://github.com/ipfs/aegir) from 22.1.0 to 25.0.0.
- [Release notes](https://github.com/ipfs/aegir/releases)
- [Changelog](https://github.com/ipfs/aegir/blob/master/CHANGELOG.md)
- [Commits](ipfs/aegir@v22.1.0...v25.0.0)

Signed-off-by: dependabot-preview[bot] <[email protected]>

* fix: use custom .eslintrc with different rules for .js and .ts (#141)

* fix: disable linter for types/types.spec.ts

* fix: use custom eslintrc instead

* fix: lint errors

* chore: enable ts support for tests

* fix: workaround ipfs/aegir#619

Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com>
Co-authored-by: Irakli Gozalishvili <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants