Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Add an info callout specifying the current state of desktop time view #7933

Merged
merged 7 commits into from
Feb 14, 2023

Conversation

LukasTy
Copy link
Member

@LukasTy LukasTy commented Feb 13, 2023

Closes #7919

Implement a suggestion mentioned in #7919 (comment)

@LukasTy LukasTy added docs Improvements or additions to the documentation component: pickers This is the name of the generic UI component, not the React module! labels Feb 13, 2023
@LukasTy LukasTy self-assigned this Feb 13, 2023
@mui-bot
Copy link

mui-bot commented Feb 13, 2023

Messages
📖 Netlify deploy preview: https://deploy-preview-7933--material-ui-x.netlify.app/

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 652.9 1,117.1 671.9 819.84 173.026
Sort 100k rows ms 654 1,021.8 654 911.72 135.941
Select 100k rows ms 210.3 258 217.5 224.22 17.316
Deselect 100k rows ms 156.2 289.6 224.8 221.72 42.566

Generated by 🚫 dangerJS against 3b162cb

@@ -55,7 +55,7 @@
"test:performance:server": "serve test/performance -p 5001",
"test:argos": "node ./scripts/pushArgos.mjs",
"typescript": "lerna run --no-bail --parallel typescript",
"typescript:ci": "lerna run --concurrency 5 --no-bail --no-sort typescript",
"typescript:ci": "lerna run --concurrency 4 --no-bail --no-sort typescript",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done a similar change as in #6850 to reduce the RAM usage and potentially avoid overflowing the available amount.
Before:
https://app.circleci.com/pipelines/github/mui/mui-x/33679/workflows/0eafce89-b995-4469-b6bd-8fe65956b51a/jobs/193177/resources
After:
https://app.circleci.com/pipelines/github/mui/mui-x/33681/workflows/3ad24b9a-5f7c-4681-84f3-8f1c5c396b39/jobs/193182/resources

Notice that we don't have a 99% and following steady usage decline signaling that the script probably exited.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are reducing the concurrency quite dramatically (the core is at 7)
If we reach 3 we might want to reconsider the resources available because if will probably start to slow down the process significantly.

Copy link
Member Author

@LukasTy LukasTy Feb 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, but for now, it does not seem to differ basically at all. 🤔
Screenshot 2023-02-14 at 13 01 04

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, MUI Core (material-ui) repo is using "Medium+" container, which has 3 CPU cores (up from 2) and 6GB of RAM (up from 4GB).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If MUI Core has a better container, maybe we could consider having it as well

@LukasTy LukasTy merged commit 500ebe3 into mui:next Feb 14, 2023
@LukasTy LukasTy deleted the add-callout-missing-desktop-time-view branch February 14, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[pickers] Time Picker / Date Time Picker do not include a UI view
3 participants