-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Add an info callout specifying the current state of desktop time view #7933
[docs] Add an info callout specifying the current state of desktop time view #7933
Conversation
These are the results for the performance tests:
|
@@ -55,7 +55,7 @@ | |||
"test:performance:server": "serve test/performance -p 5001", | |||
"test:argos": "node ./scripts/pushArgos.mjs", | |||
"typescript": "lerna run --no-bail --parallel typescript", | |||
"typescript:ci": "lerna run --concurrency 5 --no-bail --no-sort typescript", | |||
"typescript:ci": "lerna run --concurrency 4 --no-bail --no-sort typescript", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done a similar change as in #6850 to reduce the RAM usage and potentially avoid overflowing the available amount.
Before:
https://app.circleci.com/pipelines/github/mui/mui-x/33679/workflows/0eafce89-b995-4469-b6bd-8fe65956b51a/jobs/193177/resources
After:
https://app.circleci.com/pipelines/github/mui/mui-x/33681/workflows/3ad24b9a-5f7c-4681-84f3-8f1c5c396b39/jobs/193182/resources
Notice that we don't have a 99% and following steady usage decline signaling that the script probably exited.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are reducing the concurrency quite dramatically (the core is at 7)
If we reach 3 we might want to reconsider the resources available because if will probably start to slow down the process significantly.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
By the way, MUI Core (material-ui) repo is using "Medium+" container, which has 3 CPU cores (up from 2) and 6GB of RAM (up from 4GB).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If MUI Core has a better container, maybe we could consider having it as well
Closes #7919
Implement a suggestion mentioned in #7919 (comment)