-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Fix test-types
out of memory error
#6850
Conversation
These are the results for the performance tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test results are quite surprising!
Let's see if the issue returns
I sometime have crashes on But I'm fine with starting like this 👍 |
Yup. Naturally there are run-to-run variances on it's own. Also—we provide Testing most accurately would require the |
Do you have memory swap turned on? |
Yep |
Looks great 👍 |
Try tackling the same yarn error code 137 appearing when
typescript:ci
is being run.This error is thrown when the system runs out of physical memory (RAM).
Done some testing using a few different configurations:
medium+
is a one step bigger container: 6GB RAM & 3-core CPU instead of 4GB RAM & 2-core CPU.Based on the above experiments it seems that firstly going with a simple approach of reducing the concurrency is perfectly viable. Upsizing the container does yield a bit better performance, but if it costs more to us—it does not seem like it is worth the trade-off. At least at the moment, because we are not able to consume >75% of RAM.
Besides, lower concurrency does not necessarily mean longer task runtime as seen by examples and local experiments.
In any case we have somewhat low amount of cores and spawning a lot of processes requires a lot of task switching to happen when executing tasks. In our case—each of the task runtime is quite small and can benefit from lower concurrency and less CPU scheduler priority switching needed.
Related to mui/material-ui#31332