Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[docs] Add an info callout specifying the current state of desktop time view #7933

Merged
merged 7 commits into from
Feb 14, 2023
Merged

[docs] Add an info callout specifying the current state of desktop time view #7933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
fefb535
[docs] Add an info callout specifying the current state of desktop ti…
LukasTy Feb 13, 2023
4bc5e96
Code review: Flavien
LukasTy Feb 14, 2023
ac787e0
Test lower concurrency
LukasTy Feb 14, 2023
c32ee00
Print docker container info
LukasTy Feb 14, 2023
b9ba16d
Check swap usage
LukasTy Feb 14, 2023
e5ba05c
remove swap check
LukasTy Feb 14, 2023
3b162cb
Change to `you can`
LukasTy Feb 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/data/date-pickers/date-time-picker/date-time-picker.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@ materialDesign: https://m2.material.io/components/date-pickers

<p class="description">The Date Time Picker component let the user select a date and time.</p>

:::info
The component by default currently does not ship with **time** picker view experience on **desktop**.
It was a conscious decision and a first step towards having a more user friendly desktop experience [discussed in #4483](https://github.com/mui/mui-x/issues/4483).
If a desktop view experience is essential, you can revert to it by following the suggestion [in the migration guide](/x/migration/migration-pickers-v5/#stop-rendering-a-clock-on-desktop).
:::

## Basic usage

{{"demo": "BasicDateTimePicker.js"}}
Expand Down
6 changes: 6 additions & 0 deletions docs/data/date-pickers/time-picker/time-picker.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,12 @@ materialDesign: https://m2.material.io/components/time-pickers

<p class="description">The Time Picker component let the user select a time.</p>

:::info
The component by default currently does not ship with **time** picker view experience on **desktop**.
It was a conscious decision and a first step towards having a more user friendly desktop experience [discussed in #4483](https://github.com/mui/mui-x/issues/4483).
If a desktop view experience is essential, you can revert to it by following the suggestion [in the migration guide](/x/migration/migration-pickers-v5/#stop-rendering-a-clock-on-desktop).
:::

## Basic usage

{{"demo": "BasicTimePicker.js"}}
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@
"test:performance:server": "serve test/performance -p 5001",
"test:argos": "node ./scripts/pushArgos.mjs",
"typescript": "lerna run --no-bail --parallel typescript",
"typescript:ci": "lerna run --concurrency 5 --no-bail --no-sort typescript",
"typescript:ci": "lerna run --concurrency 4 --no-bail --no-sort typescript",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done a similar change as in #6850 to reduce the RAM usage and potentially avoid overflowing the available amount.
Before:
https://app.circleci.com/pipelines/github/mui/mui-x/33679/workflows/0eafce89-b995-4469-b6bd-8fe65956b51a/jobs/193177/resources
After:
https://app.circleci.com/pipelines/github/mui/mui-x/33681/workflows/3ad24b9a-5f7c-4681-84f3-8f1c5c396b39/jobs/193182/resources

Notice that we don't have a 99% and following steady usage decline signaling that the script probably exited.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are reducing the concurrency quite dramatically (the core is at 7)
If we reach 3 we might want to reconsider the resources available because if will probably start to slow down the process significantly.

Copy link
Member Author

@LukasTy LukasTy Feb 14, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, but for now, it does not seem to differ basically at all. 🤔
Screenshot 2023-02-14 at 13 01 04

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By the way, MUI Core (material-ui) repo is using "Medium+" container, which has 3 CPU cores (up from 2) and 6GB of RAM (up from 4GB).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If MUI Core has a better container, maybe we could consider having it as well

"build:codesandbox": "yarn release:build",
"install:codesandbox": "PLAYWRIGHT_SKIP_BROWSER_DOWNLOAD=1 yarn install --ignore-engines",
"release:changelog": "node scripts/releaseChangelog.mjs",
Expand Down