Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Time Picker / Date Time Picker do not include a UI view #7919

Closed
2 tasks done
sphinx9 opened this issue Feb 12, 2023 · 5 comments · Fixed by #7933
Closed
2 tasks done

[pickers] Time Picker / Date Time Picker do not include a UI view #7919

sphinx9 opened this issue Feb 12, 2023 · 5 comments · Fixed by #7933
Labels
component: DateTimePicker The React component. component: pickers This is the name of the generic UI component, not the React module! component: TimePicker The React component. discussion

Comments

@sphinx9
Copy link

sphinx9 commented Feb 12, 2023

Duplicates

  • I have searched the existing issues

Latest version

  • I have tested the latest version

Steps to reproduce 🕹

Link to live example: https://next.mui.com/x/react-date-pickers/time-picker/
Link to live example: https://next.mui.com/x/react-date-pickers/date-time-picker/

Current behavior 😯

The desktop variation of TimePicker does not include any form of picker for selecting a time - it's basically the same as the new 'Field component'. Additionally, the desktop variation of the DateTimePicker component includes a date picker, but not a time picker. The mobile and static variations of the aforementioned components are fine and include a time picker, as expected.

Expected behavior 🤔

...there should be a time picker in the Date Time Picker and Time Picker components.

Context 🔦

No response

Your environment 🌎

npx @mui/envinfo
  Don't forget to mention which browser you used.
  Output from `npx @mui/envinfo` goes here.

Order ID 💳 (optional)

No response

@sphinx9 sphinx9 added the status: waiting for maintainer These issues haven't been looked at yet by a maintainer label Feb 12, 2023
@flaviendelangle
Copy link
Member

flaviendelangle commented Feb 13, 2023

Hi,

Thanks for your feedback
You have more context on the migration guide and on #4483.

From the feedback we gathered from the community, the Clock is not a good way of picking a date on destkop.
We preferred to rely only on the field editing at first, to be able to remove the Clock in a minor release without waiting for v7.
This seems to be a good trade-off because people can add back the Clock very easily if they want to.
The work is already quite advanced for this new UI, so it should be for one of the first release after the stable, but we can't give a precise deadline yet.

@flaviendelangle flaviendelangle changed the title Time Picker / Date Time Picker do not include a time picker. [pickers] Time Picker / Date Time Picker do not include a UI view Feb 13, 2023
@flaviendelangle flaviendelangle added discussion component: pickers This is the name of the generic UI component, not the React module! component: DateTimePicker The React component. component: TimePicker The React component. and removed status: waiting for maintainer These issues haven't been looked at yet by a maintainer labels Feb 13, 2023
@flaviendelangle
Copy link
Member

Maybe we should add a note on the TimePicker and DateTimePicker v6 pages to briefly explain that

@oliviertassinari
Copy link
Member

oliviertassinari commented Feb 13, 2023

If I understand the use case correctly, the "popover" is meant for end-users that are using their mouse pointer, but are either:

  1. too lazy to switch to the keyboard. It makes sense, it can be more effort to move its hand to press a keystroke than moving the cursor and clicking a bit.
  2. are used to the popover UX pattern. They don't even think about using their keyboard.

?

@LukasTy
Copy link
Member

LukasTy commented Feb 14, 2023

If I understand the use case correctly, the "popover" is meant for end-users that are using their mouse pointer, but are either:

  1. too lazy to switch to the keyboard. It makes sense, it can be more effort to move its hand to press a keystroke than moving the cursor and clicking a bit.
  2. are used to the popover UX pattern. They don't even think about using their keyboard.

?

Yes, I'd agree with both of your assumptions. We need to take care of as many possible use cases as possible and it's probably only a small percentage of power users, who, would be very happy with the approach of the new field and use only it to enter data, but the majority of casual users are probably used to having some sort of mouse/view based behaviors of interacting with data. 👍

@oliviertassinari
Copy link
Member

oliviertassinari commented Feb 14, 2023

@sphinx9 So to be clear, we moved your pain point to #4483, you can subscribe to this issue close event.

Screenshot 2023-02-14 at 12 51 43

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: DateTimePicker The React component. component: pickers This is the name of the generic UI component, not the React module! component: TimePicker The React component. discussion
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants