Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Copy and upgrade parts of DynamoStorage into autoendpoint #174

Merged
merged 5 commits into from
Jul 21, 2020
Merged

fix: Copy and upgrade parts of DynamoStorage into autoendpoint #174

merged 5 commits into from
Jul 21, 2020

Conversation

AzureMarker
Copy link
Contributor

@AzureMarker AzureMarker commented Jul 10, 2020 •
edited
Loading

Major changes:

  • Autoendpoint no longer uses any Tokio 0.1 code (and consequently doesn't crash). The autopush_common database code has been copied and converted into Tokio 0.2 (futures 0.3) code.
  • The autoendpoint message_table_name setting is now the exact name of the message table to use (previously it was a prefix, used in legacy table rotation code).

Minor changes:

  • A database.retry metric is incremented whenever a database operation is retried.
  • Some of the autopush_common macros are exported so they can be used in the autoendpoint database client.
  • The autoendpoint database client returns an option for get_user instead of an error if it doesn't exist.

Closes #172

@AzureMarker AzureMarker added this to the Autoendpoint Rust Server milestone Jul 10, 2020
@AzureMarker AzureMarker changed the title Copy and upgrade parts of DynamoStorage into autoendpoint bug: Copy and upgrade parts of DynamoStorage into autoendpoint Jul 10, 2020
@AzureMarker AzureMarker linked an issue Jul 10, 2020 that may be closed by this pull request
Fix incompatibility between Tokio 0.2 and 0.1 #172
Closed
jrconlin
jrconlin previously approved these changes Jul 10, 2020
View reviewed changes
@AzureMarker AzureMarker mentioned this pull request Jul 13, 2020
Merged
@AzureMarker AzureMarker force-pushed the feat/autoendpoint-fcm-router branch from 64c6f5f to 14abb92 Compare July 13, 2020 18:19
@AzureMarker AzureMarker force-pushed the fix/actix-tokio-incompatibility branch from 991a21b to 8845fab Compare July 13, 2020 18:35
@AzureMarker AzureMarker changed the title bug: Copy and upgrade parts of DynamoStorage into autoendpoint fix: Copy and upgrade parts of DynamoStorage into autoendpoint Jul 13, 2020
This was referenced Jul 15, 2020
Merged
Merged
@AzureMarker AzureMarker marked this pull request as ready for review July 17, 2020 19:06
Base automatically changed from feat/autoendpoint-fcm-router to master July 20, 2020 13:16
@AzureMarker AzureMarker dismissed jrconlin’s stale review July 20, 2020 13:16

The base branch was changed.

@AzureMarker AzureMarker force-pushed the fix/actix-tokio-incompatibility branch from 8845fab to 7086e1a Compare July 20, 2020 13:59
@AzureMarker AzureMarker requested a review from jrconlin July 20, 2020 13:59
@AzureMarker AzureMarker requested a review from jrconlin July 21, 2020 13:13
@AzureMarker AzureMarker force-pushed the fix/actix-tokio-incompatibility branch from 4ed59b3 to a11591b Compare July 21, 2020 14:06
@AzureMarker
Copy and upgrade parts of DynamoStorage into autoendpoint
6d79930 
Autoendpoint no longer uses any Tokio 0.1 code (and consequently doesn't
crash).

Some of the autopush_common macros are exported so they can be used in
the autoendpoint database client.

The autoendpoint database client returns an option for get_user instead
of an error if it doesn't exist.
@AzureMarker
Don't expose internal database error messages in responses
580f245
@AzureMarker
Fix hashmap macro example
7a19efd
@AzureMarker
Enable the log feature of "again"
663442e
@AzureMarker
Handle both serialization AND deserialization errors in DbClient
89813f6
@AzureMarker AzureMarker force-pushed the fix/actix-tokio-incompatibility branch from a11591b to 89813f6 Compare July 21, 2020 14:37
@AzureMarker AzureMarker merged commit 120a46b into master Jul 21, 2020
@AzureMarker AzureMarker deleted the fix/actix-tokio-incompatibility branch July 21, 2020 16:40
This was referenced Oct 16, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrconlin jrconlin jrconlin approved these changes

@pjenvey pjenvey Awaiting requested review from pjenvey

@fzzzy fzzzy Awaiting requested review from fzzzy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Autoendpoint Rust Server
Development

Successfully merging this pull request may close these issues.

Fix incompatibility between Tokio 0.2 and 0.1
2 participants
@AzureMarker @jrconlin