Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incompatibility between Tokio 0.2 and 0.1 #172

Closed
AzureMarker opened this issue Jul 9, 2020 · 0 comments · Fixed by #174 or #231
Closed

Fix incompatibility between Tokio 0.2 and 0.1 #172

AzureMarker opened this issue Jul 9, 2020 · 0 comments · Fixed by #174 or #231
Assignees
@AzureMarker
Labels
3 Estimate - Small...ish
Milestone
Autoendpoint Rust...

Comments

@AzureMarker
Copy link
Contributor

AzureMarker commented Jul 9, 2020 •
edited
Loading

Background: https://github.com/actix/actix-web/issues/1593

This incompatibility causes a crash in autoendpoint after running for a few minutes, when handling a request.

Due to this incompatibility, we must copy and update whatever code autoendpoint uses from autopush_common into Tokio 0.2 (futures 0.3) compatible code. Until Actix fixes the runtime issue or we upgrade the rest of the autopush codebase to Tokio 0.2, autoendpoint cannot use any Tokio 0.1 code.
@AzureMarker AzureMarker added the 3 Estimate - Small...ish label Jul 9, 2020
@AzureMarker AzureMarker added this to the Autoendpoint Rust Server milestone Jul 9, 2020
@AzureMarker AzureMarker self-assigned this Jul 9, 2020
@AzureMarker AzureMarker mentioned this issue Jul 10, 2020
Merged
@AzureMarker AzureMarker linked a pull request Jul 10, 2020 that will close this issue
fix: Copy and upgrade parts of DynamoStorage into autoendpoint #174
Merged
AzureMarker added a commit that referenced this issue Jul 21, 2020
@AzureMarker
fix: Copy and upgrade parts of DynamoStorage into autoendpoint (#174)
120a46b 
* Copy and upgrade parts of DynamoStorage into autoendpoint

Autoendpoint no longer uses any Tokio 0.1 code (and consequently doesn't
crash).

Some of the autopush_common macros are exported so they can be used in
the autoendpoint database client.

The autoendpoint database client returns an option for get_user instead
of an error if it doesn't exist.

* Don't expose internal database error messages in responses

* Fix hashmap macro example

* Enable the log feature of "again"

* Handle both serialization AND deserialization errors in DbClient

Closes #172
This was referenced Oct 16, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AzureMarker AzureMarker

Labels
3 Estimate - Small...ish
Projects
None yet
Milestone
Autoendpoint Rust Server
1 participant
@AzureMarker