Handle both serialization AND deserialization errors in DbClient

mozilla-services · Jul 21, 2020 · a11591b · a11591b
1 parent a5bf7a8
commit a11591b
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 4 deletions.
diff --git a/autoendpoint/src/db/client.rs b/autoendpoint/src/db/client.rs
@@ -166,8 +166,7 @@ impl DbClient {
     /// Store a single message
     pub async fn store_message(&self, uaid: Uuid, message: Notification) -> DbResult<()> {
         let put_item = PutItemInput {
-            item: serde_dynamodb::to_hashmap(&DynamoDbNotification::from_notif(&uaid, message))
-                .unwrap(),
+            item: serde_dynamodb::to_hashmap(&DynamoDbNotification::from_notif(&uaid, message))?,
             table_name: self.message_table.clone(),
             ..Default::default()
         };

diff --git a/autoendpoint/src/db/error.rs b/autoendpoint/src/db/error.rs
@@ -19,6 +19,6 @@ pub enum DbError {
     #[error("Database error while performing DeleteItem")]
     DeleteItem(#[from] RusotoError<DeleteItemError>),
 
-    #[error("Error while deserializing database response: {0}")]
-    Deserialize(#[from] serde_dynamodb::Error),
+    #[error("Error while performing (de)serialization: {0}")]
+    Serialization(#[from] serde_dynamodb::Error),
 }