Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Delete message endpoint #186

Merged
merged 6 commits into from
Jul 27, 2020
Merged

feat: Delete message endpoint #186

merged 6 commits into from
Jul 27, 2020

Conversation

AzureMarker
Copy link
Contributor

@AzureMarker AzureMarker commented Jul 16, 2020 •
edited
Loading

Adds the DELETE /m/{message_id} endpoint.

Closes #175

@AzureMarker AzureMarker added this to the Autoendpoint Rust Server milestone Jul 16, 2020
@AzureMarker AzureMarker marked this pull request as draft July 16, 2020 14:18
@AzureMarker AzureMarker linked an issue Jul 16, 2020 that may be closed by this pull request
[autoendpoint] Support message deletion endpoint #175
Closed
@AzureMarker AzureMarker marked this pull request as ready for review July 17, 2020 19:07
jrconlin
jrconlin previously approved these changes Jul 17, 2020
View reviewed changes
@AzureMarker AzureMarker force-pushed the fix/actix-tokio-incompatibility branch from 8845fab to 7086e1a Compare July 20, 2020 13:59
@AzureMarker AzureMarker force-pushed the feat/delete-message-endpoint branch from d627f91 to 6fb2749 Compare July 20, 2020 14:03
@AzureMarker AzureMarker force-pushed the fix/actix-tokio-incompatibility branch from 4ed59b3 to a11591b Compare July 21, 2020 14:06
@AzureMarker AzureMarker force-pushed the feat/delete-message-endpoint branch from 6fb2749 to 33971c1 Compare July 21, 2020 14:08
@AzureMarker AzureMarker force-pushed the fix/actix-tokio-incompatibility branch from a11591b to 89813f6 Compare July 21, 2020 14:37
@AzureMarker AzureMarker force-pushed the feat/delete-message-endpoint branch from 33971c1 to ad8b44b Compare July 21, 2020 14:38
Base automatically changed from fix/actix-tokio-incompatibility to master July 21, 2020 16:40
@AzureMarker AzureMarker dismissed jrconlin’s stale review July 21, 2020 16:40

The base branch was changed.

@AzureMarker AzureMarker force-pushed the feat/delete-message-endpoint branch from ad8b44b to 5f77b08 Compare July 21, 2020 16:46
@AzureMarker AzureMarker requested a review from jrconlin July 21, 2020 16:47
jrconlin
jrconlin previously approved these changes Jul 27, 2020
View reviewed changes
@AzureMarker
Merge branch 'master' into feat/delete-message-endpoint
f9c41b7 
# Conflicts:
#	autoendpoint/src/error.rs
#	autoendpoint/src/server.rs
@AzureMarker AzureMarker requested a review from jrconlin July 27, 2020 16:10
@AzureMarker
Copy link
Contributor Author

Sorry JR! Looks like GitHub didn't want to carry over your review after the last master merge.

@AzureMarker AzureMarker merged commit 6a7fa49 into master Jul 27, 2020
@AzureMarker AzureMarker deleted the feat/delete-message-endpoint branch July 27, 2020 17:01
This was referenced Oct 16, 2020
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrconlin jrconlin jrconlin approved these changes

@pjenvey pjenvey Awaiting requested review from pjenvey

@fzzzy fzzzy Awaiting requested review from fzzzy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Autoendpoint Rust Server
Development

Successfully merging this pull request may close these issues.

[autoendpoint] Support message deletion endpoint
2 participants
@AzureMarker @jrconlin