Skip to content
This repository has been archived by the owner on Nov 1, 2022. It is now read-only.

Closes #7644: Add long click listener to BrowserMenuItemToolbar items. #7679

Merged
merged 1 commit into from
Jul 13, 2020
Merged

Closes #7644: Add long click listener to BrowserMenuItemToolbar items. #7679

merged 1 commit into from
Jul 13, 2020
+48 −0

Conversation

person808
Copy link
Contributor

@person808 person808 commented Jul 10, 2020 •
edited
Loading

Needed for mozilla-mobile/fenix#1048 and mozilla-mobile/fenix#2681

Pull Request checklist

  • Quality: This PR builds and passes detekt/ktlint checks (A pre-push hook is recommended)
  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Changelog: This PR includes a changelog entry or does not need one
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features

After merge

  • Milestone: Make sure issues closed by this pull request are added to the milestone of the version currently in development.
  • Breaking Changes: If this is a breaking change, please push a draft PR on Reference Browser to address the breaking issues.

@person808 person808 changed the title Closes #7644: Add long click listener parameter to BrowserMenuItemToo… Closes #7644: Add long click listener to BrowserMenuItemToolbar items. Jul 10, 2020
@person808 person808 added the 🕵️‍♀️ needs review PRs that need to be reviewed label Jul 10, 2020
@person808 person808 requested a review from psymoon July 10, 2020 19:59
@pocmo pocmo self-assigned this Jul 13, 2020
psymoon
psymoon approved these changes Jul 13, 2020
View reviewed changes
Copy link
Contributor

@psymoon psymoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me :).

@person808 person808 mentioned this pull request Jul 13, 2020
Merged
4 tasks
@person808 person808 removed the 🕵️‍♀️ needs review PRs that need to be reviewed label Jul 13, 2020
@person808
Copy link
Contributor Author

bors r=psymoon

@bors
Copy link

bors bot commented Jul 13, 2020

Build succeeded:

@bors bors bot merged commit cdef87e into mozilla-mobile:master Jul 13, 2020
@person808 person808 deleted the longpress-menu branch July 13, 2020 18:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@psymoon psymoon psymoon approved these changes

Assignees

@pocmo pocmo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@person808 @psymoon @pocmo