Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

For #1048 - Add ability to view tab history by long-pressing the back or forward button. #12519

Merged
merged 1 commit into from
Jul 22, 2020

Conversation

person808
Copy link
Contributor

@person808 person808 commented Jul 13, 2020

Pull Request checklist

  • Tests: This PR includes thorough tests or an explanation of why it does not
  • Screenshots: This PR includes screenshots or GIFs of the changes made or an explanation of why it does not
  • Accessibility: The code in this PR follows accessibility best practices or does not include any user facing features. In addition, it includes a screenshot of a successful accessibility scan to ensure no new defects are added to the product.

After merge

  • Milestone: Make sure issues finished by this pull request are added to the milestone of the version currently in development.

To download an APK when reviewing a PR:

  1. click on Show All Checks,
  2. click Details next to "Taskcluster (pull_request)" after it appears and then finishes with a green checkmark,
  3. click on the "Fenix - assemble" task, then click "Run Artifacts".
  4. the APK links should be on the left side of the screen, named for each CPU architecture

@person808 person808 changed the title For #1048 - Add ability to view tab history by long-pressing the back or For #1048 - Add ability to view tab history by long-pressing the back or forward button. Jul 13, 2020
@person808 person808 force-pushed the feature-1048 branch 4 times, most recently from f8ebc0e to b6638c6 Compare July 16, 2020 17:38
@codecov-commenter
Copy link

codecov-commenter commented Jul 16, 2020

Codecov Report

Merging #12519 into master will decrease coverage by 0.09%.
The diff coverage is 12.50%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master   #12519      +/-   ##
============================================
- Coverage     26.75%   26.66%   -0.10%     
- Complexity      942      944       +2     
============================================
  Files           398      404       +6     
  Lines         15912    16008      +96     
  Branches       2042     2050       +8     
============================================
+ Hits           4258     4269      +11     
- Misses        11325    11412      +87     
+ Partials        329      327       -2     
Impacted Files Coverage Δ Complexity Δ
...pp/src/main/java/org/mozilla/fenix/HomeActivity.kt 6.45% <0.00%> (-0.45%) 13.00 <0.00> (ø)
...a/org/mozilla/fenix/browser/BaseBrowserFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...lla/fenix/components/toolbar/DefaultToolbarMenu.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...g/mozilla/fenix/customtabs/CustomTabToolbarMenu.kt 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...zilla/fenix/tabhistory/TabHistoryDialogFragment.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...ava/org/mozilla/fenix/tabhistory/TabHistoryView.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
...g/mozilla/fenix/tabhistory/TabHistoryViewHolder.kt 0.00% <0.00%> (ø) 0.00 <0.00> (?)
.../org/mozilla/fenix/tabhistory/TabHistoryAdapter.kt 13.33% <13.33%> (ø) 0.00 <0.00> (?)
...nix/components/toolbar/BrowserToolbarController.kt 70.17% <100.00%> (+0.53%) 0.00 <0.00> (ø)
...rg/mozilla/fenix/components/toolbar/ToolbarMenu.kt 100.00% <100.00%> (ø) 0.00 <0.00> (ø)
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afbb039...dc89f85. Read the comment docs.

@boek boek added the eng:perf-impact This issue may have an impact on performance: the perf team will investigate label Jul 21, 2020
@boek boek merged commit 921b162 into mozilla-mobile:master Jul 22, 2020
@person808 person808 deleted the feature-1048 branch July 22, 2020 18:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
eng:perf-impact This issue may have an impact on performance: the perf team will investigate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants