Skip to content
This repository has been archived by the owner on Feb 20, 2023. It is now read-only.

Ability to force-refresh a tab #2681

Closed
buttercookie42 opened this issue May 21, 2019 · 4 comments
Closed

Ability to force-refresh a tab #2681

buttercookie42 opened this issue May 21, 2019 · 4 comments
Labels
eng:qa:verified QA Verified Feature:FennecTransition Feature:MainMenu The three-dot menu that is seen on the browser and homescreen. feature request 🌟 New functionality and improvements needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org

Comments

@buttercookie42
Copy link

buttercookie42 commented May 21, 2019 •
edited by data-sync-user
Loading

Long pressing the reload button in Fennec triggers a forced refresh that bypasses the cache. Likely needs some additional GeckoView-support, because while it seems possible to pass LOAD_FLAGS_BYPASS_CACHE when loading an URL, there are currently no options possible for _re_loading the current page.

┆Issue is synchronized with this Jira Task
@bifleming bifleming added this to the Post-MVP Backlog milestone May 21, 2019
@bifleming bifleming added P2 Upcoming release Feature:MainMenu The three-dot menu that is seen on the browser and homescreen. feature request 🌟 New functionality and improvements labels May 21, 2019
@vesta0 vesta0 removed P2 Upcoming release labels Jul 2, 2019
@vesta0 vesta0 modified the milestone: Feature Backlog Jul 26, 2019
@buttercookie42 buttercookie42 mentioned this issue Nov 7, 2019
Closed
@NotWoods NotWoods added the needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org label Dec 23, 2019
@cadeyrn cadeyrn mentioned this issue Jan 29, 2020
Closed
@buttercookie42
Copy link
Author

Bugs 1618958 and 1623712 have been fixed, so it should be possible to implement this now, shouldn't it?

@buttercookie42 buttercookie42 mentioned this issue Apr 17, 2020
Closed
@person808 person808 mentioned this issue Jul 10, 2020
Merged
4 tasks
boek added a commit to boek/android-components that referenced this issue Jul 13, 2020
@boek
For mozilla-mobile/fenix#2681 - Adds bypassCache parameter to reload.
99c2e13
boek added a commit to boek/android-components that referenced this issue Jul 14, 2020
@boek
For mozilla-mobile/fenix#2681 - Adds bypassCache parameter to reload.
6080812
boek added a commit to boek/android-components that referenced this issue Jul 14, 2020
@boek
For mozilla-mobile/fenix#2681 - Adds bypassCache parameter to reload.
c358ccf
boek added a commit to boek/android-components that referenced this issue Jul 14, 2020
@boek
For mozilla-mobile/fenix#2681 - Adds bypassCache parameter to reload.
b931ccb
boek added a commit to boek/fenix that referenced this issue Jul 14, 2020
@boek
For mozilla-mobile#2681 - Adds ability to bypass cache when reloading
573b6a1
boek added a commit to boek/fenix that referenced this issue Jul 14, 2020
@boek
For mozilla-mobile#2681 - Adds ability to bypass cache when reloading
ee93c3d
boek added a commit to boek/fenix that referenced this issue Jul 20, 2020
@boek
For mozilla-mobile#2681 - Adds ability to bypass cache when reloading
83dc37c
boek added a commit to boek/fenix that referenced this issue Jul 22, 2020
@boek
For mozilla-mobile#2681 - Adds ability to bypass cache when reloading
a5d911a
boek added a commit to boek/fenix that referenced this issue Jul 22, 2020
@boek
For mozilla-mobile#2681 - Adds ability to bypass cache when reloading
bda6f86
@issue-dispenser
Copy link

@boek
Would it be within UX guidelines to handle both this feature and #9956 at the same time by using a menu on long-pressing the refresh button (similar to how long-pressing the tab counter button opens a menu with 3 items)? In this case there would be two items: Refresh Bypassing Cache and Refresh In New Tab.

boek added a commit to boek/fenix that referenced this issue Jul 27, 2020
@boek
For mozilla-mobile#2681 - Adds ability to bypass cache when reloading
67d9fe7
boek added a commit that referenced this issue Jul 27, 2020
@boek
For #2681 - Adds ability to bypass cache when reloading
46f010f
@boek boek added the eng:qa:needed QA Needed label Aug 7, 2020
@ebalazs-sv
Copy link

ebalazs-sv commented Aug 10, 2020 •
edited
Loading

Verified as fixed on Nightly 200810 (Build #2015757107) GV 81.0a1 from 8/10 with the following devices:

  • Pixel 4 XL (Android 11);
  • Google Pixel 3a (Android 10);
  • Pixel 2 (Android 9);
  • Huawei P9 Lite (Android 7);
  • Samsung Galaxy Tab S3 (Android 8);
  • Nexus 5 (Android 6.0.1);
  • Nexus 4 (Android 5);
  • Huawei MediaPad M2 (Android 5.1.1).

Verified this issue in normal browsing, private browsing, custom tab, homescreen shortcuts, PWA and the page is force-refreshed when long tapping the Reload button.
I will remove the qa:needed label for now.

@ebalazs-sv ebalazs-sv added eng:qa:verified QA Verified and removed eng:qa:needed QA Needed labels Aug 10, 2020
@madb1lly
Copy link

Hooray! 😃

@data-sync-user data-sync-user changed the title Ability to force-refresh a tab FNX3-16508 ⁃ Ability to force-refresh a tab Aug 11, 2020
@person808 person808 mentioned this issue Aug 25, 2020
Closed
@TrianguloY TrianguloY mentioned this issue Sep 17, 2020
Closed
@data-sync-user data-sync-user changed the title FNX3-16508 ⁃ Ability to force-refresh a tab Ability to force-refresh a tab May 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
eng:qa:verified QA Verified Feature:FennecTransition Feature:MainMenu The three-dot menu that is seen on the browser and homescreen. feature request 🌟 New functionality and improvements needs:gv GeckoView bug required to fix the issue. See bugzilla.mozilla.org
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
10 participants
@kbrosnan @boek @NotWoods @buttercookie42 @issue-dispenser @madb1lly @vesta0 @bifleming @ebalazs-sv @data-sync-user