-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Export Schema Registry client and the serdes functionality #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mostafa
force-pushed
the
export-schema-registry-client
branch
from
August 7, 2022 22:49
c5ab03a
to
7b25137
Compare
Update tests to reflect changes
…he way data types and schemas are handled now Update tests to reflect changes to the serdes functions
…ntion Update writer and reader to remove internal serdes functions Update tests to reflect the new changes
mostafa
force-pushed
the
export-schema-registry-client
branch
from
August 8, 2022 22:31
7b25137
to
0bab0ba
Compare
This was
linked to
issues
Aug 9, 2022
mostafa
changed the title
[WIP] Export Schema Registry client and the serdes functionality
Export Schema Registry client and the serdes functionality
Aug 10, 2022
@fdahunsibread @enamrik @kusumkappdirect |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information |
This was referenced Aug 10, 2022
This was referenced Aug 11, 2022
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR I tried to address the following issues. While doing so, I created a
SchemaRegistry
object and updated the serdes functionality to export the whole Schema Registry client and theserialize
anddeserialize
functions to the JS code. Contrary to my initial testing, the new changes make the code faster and more performant. And the following is the result. The updated examples can be found in thescripts
directory.And this is the result of running the famous
scripts/test_json.js
for a minute and 50 VUs, which is impressive.Terminal output of the test
Tasks: