Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test pipeline and add test for all scripts #48

Closed
mostafa opened this issue May 6, 2022 · 3 comments
Closed

Fix test pipeline and add test for all scripts #48

mostafa opened this issue May 6, 2022 · 3 comments
Labels
✨ Feature Request New feature or request

Comments

@mostafa
Copy link
Owner

mostafa commented May 6, 2022 •
edited
Loading

The reason is explained in the description of the #46 PR.

As a side note, the tests might look flaky (work sometimes and fails other times), but the actual reason is that I introduced thresholds on custom Kafka metrics and also added checks to verify produced and consumed messages. So, this behavior is expected. I am going to fix the test later in #48.
@mostafa mostafa mentioned this issue May 6, 2022
Merged
@mostafa mostafa added the ✨ Feature Request New feature or request label May 7, 2022
@mostafa mostafa moved this to Todo in xk6-kafka May 10, 2022
@mostafa mostafa changed the title Fix test pipeline Fix test pipeline and add test for all scripts May 12, 2022
@mostafa
Copy link
Owner Author

mostafa commented May 17, 2022

Fixed by #60.

@mostafa mostafa closed this as completed May 17, 2022
Repository owner moved this from Todo to Test in xk6-kafka May 17, 2022
@mostafa
Copy link
Owner Author

mostafa commented May 18, 2022

I'll reopen it because I haven't yet added tests for all the scripts.

@mostafa mostafa reopened this May 18, 2022
Repository owner moved this from Test to Doing in xk6-kafka May 18, 2022
@mostafa mostafa moved this from Doing to Todo in xk6-kafka May 18, 2022
@mostafa
Copy link
Owner Author

mostafa commented Aug 10, 2022 •
edited
Loading

Added more tests in #149 and enabled running all test scripts, except the scripts/test_sasl_auth.js, in f2bd747. Until I can fix the Kafka to run the SASL auth script, I'll skip it.

@mostafa mostafa moved this from Todo to Doing in xk6-kafka Aug 10, 2022
@mostafa mostafa mentioned this issue Aug 10, 2022
Open
@mostafa mostafa closed this as completed Aug 11, 2022
Repository owner moved this from Doing to Test in xk6-kafka Aug 11, 2022
@mostafa mostafa moved this from Test to Release in xk6-kafka Aug 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
✨ Feature Request New feature or request
Projects
xk6-kafka
Status: Release
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mostafa