Fix linting issues by removing unnecessary code or fixing reported is…

…sues
mostafa · Aug 8, 2022 · 0bab0ba · 0bab0ba
1 parent 0d9184b
commit 0bab0ba
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 8 deletions.
diff --git a/schema_registry.go b/schema_registry.go
@@ -195,7 +195,7 @@ func (k *Kafka) schemaRegistryClientClass(call goja.ConstructorCall) *goja.Objec
 		}
 
 		var metadata *Container
-		if params, ok := call.Argument(0).Export().(interface{}); ok {
+		if params, ok := call.Argument(0).Export().(map[string]interface{}); ok {
 			if b, err := json.Marshal(params); err != nil {
 				common.Throw(runtime, err)
 			} else {
@@ -217,7 +217,7 @@ func (k *Kafka) schemaRegistryClientClass(call goja.ConstructorCall) *goja.Objec
 		}
 
 		var metadata *Container
-		if params, ok := call.Argument(0).Export().(interface{}); ok {
+		if params, ok := call.Argument(0).Export().(map[string]interface{}); ok {
 			if b, err := json.Marshal(params); err != nil {
 				common.Throw(runtime, err)
 			} else {

diff --git a/serdes_test.go b/serdes_test.go
@@ -109,7 +109,7 @@ func TestSerdes(t *testing.T) {
 		})
 		assert.Equal(t, 1, len(messages))
 
-		if value, ok := messages[0]["value"].(interface{}); ok {
+		if value, ok := messages[0]["value"].(map[string]interface{}); ok {
 			// Deserialize the key or value (removes the magic bytes).
 			deserialized := test.module.Kafka.deserialize(&Container{
 				Data:       value,

diff --git a/utils.go b/utils.go
@@ -3,7 +3,6 @@ package kafka
 import (
 	"encoding/base64"
 	"encoding/json"
-	"unicode/utf8"
 
 	"github.com/dop251/goja"
 )
@@ -61,7 +60,3 @@ func isJSON(data []byte) bool {
 	}
 	return false
 }
-
-func isValidUTF8String(data []byte) bool {
-	return utf8.Valid(data)
-}