-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable selective schema caching #151
Conversation
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Hi @mostafa , The way I use the xk6-kafka to test our microservices is by generating million of events which can be consumed by the microservice under test, that's because I need do the test with schema registry (consumers use it), and also I want to enable cache by default, because:
I was testing the solution with master branch, as summary the test now produce 11414 and previously 257870 with 50vu in 1 minute. I'm trying to figure out what's happening on master branch, any help will be appreciated :) This is my schema registry configuration:
And this is the test configuration:
Result is: 11414 message count However with previous branch with the patch (https://github.com/oscar067/xk6-kafka) : 257870 @riferrei With previous branch I also did some tests using the sync.Map in https://github.com/oscar067/srclient/tree/v1.0.1 and it wrote 18614 (with previous xk6-kafka) master branch Seems it improves the performance. |
@oscar067 The Also, have you changed your code to use the changes in #149? |
Based on issue #146 reported by @oscar067 and the fix in PR #147 by the same awesome person, I created this PR to address the same issue from my own POV to achieve two objectives:
@oscar067 WDYT?