Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Configurable favicon, solves #34 #42

Merged
merged 3 commits into from
Jul 7, 2022
Merged

Feature: Configurable favicon, solves #34 #42

merged 3 commits into from
Jul 7, 2022

Conversation

abias
Copy link
Member

@abias abias commented Jul 5, 2022

This patch allows the admin to upload a custom favicon which will then be used instead of the default Moodle favicon.


Please note that this PR is built on top of PR #40 and should be merged in line.

abias added 3 commits July 5, 2022 14:30
This patch adds an admin setting which allows the admin to add a back to top button to the page. The button will appear in the bottom right corner of the page as soon as the user scrolls down the page.

A button like this existed already on Boost in Moodle Core until Moodle 3.11, but was removed in 4.0. With Boost Union, you can bring it back.
This patch introduces the theme/boost_union:configure capability which allows managers to configure the theme as non-admin. By default, the capability is assigned to no role at all.
This patch allows the admin to upload a custom favicon which will then be used instead of the default Moodle favicon.
Copy link
Collaborator

@lucaboesch lucaboesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've review and tested this change.
Looking all good.
Merging.

@lucaboesch lucaboesch merged commit 56566b5 into master Jul 7, 2022
@lucaboesch lucaboesch deleted the issue-34 branch July 7, 2022 11:36
wiebkemueller-hsh referenced this pull request in christianwolters/moodle-theme_boost_union Feb 8, 2024
detomon pushed a commit to detomon/moodle-theme_boost_union that referenced this pull request Aug 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants