Fix cohort/rule deletion, resolves #737 (MOODLE_401_STABLE) #741
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marxjohnson
changed the title
|
It looks like the "8.1, MOODLE_401_STABLE, pgsql" run failed due to a random crash. @abias are you able to retrigger that job? |
marxjohnson
force-pushed
the
737-cohort-deletion-bug_401
branch
from
eb84286 to
bc4661c
Compare
|
Hi @marxjohnson , thank you very much for backporting the patch from #739 to the 4.1 stable branch. Cheers, |
abias
merged commit 9072447
into
moodle-an-hochschulen:MOODLE_401_STABLE
6 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On behalf of the Boost Union Team: 🎉 Thank you for contributing! 🎉
Please note: There must be a GitHub issue for every pull request (PR)
We kindly ask you to create a github issue now if you haven't already done so.
Please make sure to follow these steps to ease the review process for the peer review team:
[ ] link your issue in the PR title, using the keyword 'resolves #ISSUE-NUMBER', e.g. 'Feature: Provide the ultimate user experience, resolves #42'
[ ] provide any further information that is relevant for peer review and not yet mentioned in the linked issue as a comment in the PR
[ ] make sure that the 'Allow edits by maintainers' checkbox is checked when creating the PR. Otherwise, the peer reviewer would not be able to push any review changes to the PR and the communication overhead increases
[ ] submit your PR in draft status to run the automated checks and review the results
[ ] in case any checks fail solve the mentioned errors by pushing the corrected code to your PR-branch
[ ] if all checks pass (or if you are unable to resolve the failing steps without any help of the review team), mark the PR as 'ready for review'
Thank you again for your contribution, we will start reviewing your PR as soon as we are able to.
In the meantime, please check our wiki page for creating pull requests and our wiki page for reviewing pull requests for further infomation about our contribution and review process.