Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Configurable favicon #34

Closed
abias opened this issue Jul 1, 2022 · 3 comments
Closed

Feature: Configurable favicon #34

abias opened this issue Jul 1, 2022 · 3 comments
Assignees
@abias
Labels
feature Something which is a new feature or big improvement

Comments

@abias
Copy link
Member

abias commented Jul 1, 2022

Currently, Boost Union does not ship with a favicon.ico file in /pix. The favicon() functon in the output renderer simply picks the favicon file from the active theme and delivers it to the browser. For Boost Union, no favicon can be delivered currently.

A favicon file should be added to the theme and, even better, the favicon should be made configurable in the theme settings like it has been possible in Boost Campus.
@abias abias added the feature Something which is a new feature or big improvement label Jul 1, 2022
@abias abias self-assigned this Jul 1, 2022
abias added a commit that referenced this issue Jul 5, 2022
@abias
Feature: Configurable favicon, solves #34
5e8f862 
This patch allows the admin to upload a custom favicon which will then be used instead of the default Moodle favicon.
abias added a commit that referenced this issue Jul 5, 2022
@abias
Feature: Configurable favicon, solves #34
57bf9cd 
This patch allows the admin to upload a custom favicon which will then be used instead of the default Moodle favicon.
@abias
Copy link
Member Author

abias commented Jul 5, 2022

I submitted a PR for this issue in #42 42

lucaboesch added a commit that referenced this issue Jul 7, 2022
@lucaboesch
Merge pull request #42 from moodle-an-hochschulen/issue-34
56566b5 
Feature: Configurable favicon, solves #34
@lucaboesch
Copy link
Collaborator

Done

@lucaboesch
Copy link
Collaborator

Beginning with Moodle 4.1, this will then be a standard featore of core Moodle see https://tracker.moodle.org/browse/MDL-75218 and can then be removed.
I created #78

detomon pushed a commit to detomon/moodle-theme_boost_union that referenced this issue Aug 26, 2024
@abias
Feature: Configurable favicon, solves moodle-an-hochschulen#34
76568d9 
This patch allows the admin to upload a custom favicon which will then be used instead of the default Moodle favicon.
detomon pushed a commit to detomon/moodle-theme_boost_union that referenced this issue Aug 26, 2024
@lucaboesch
Merge pull request moodle-an-hochschulen#42 from moodle-an-hochschule…
ef5dac9 
…n/issue-34

Feature: Configurable favicon, solves moodle-an-hochschulen#34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@abias abias

Labels
feature Something which is a new feature or big improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lucaboesch @abias