Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cohort/rule deletion, resolves #737 (MOODLE_405_STABLE) #743

Conversation

marxjohnson
Copy link
Contributor

On behalf of the Boost Union Team: 🎉 Thank you for contributing! 🎉

Please note: There must be a GitHub issue for every pull request (PR)

We kindly ask you to create a github issue now if you haven't already done so.

Please make sure to follow these steps to ease the review process for the peer review team:

[ ] link your issue in the PR title, using the keyword 'resolves #ISSUE-NUMBER', e.g. 'Feature: Provide the ultimate user experience, resolves #42'
[ ] provide any further information that is relevant for peer review and not yet mentioned in the linked issue as a comment in the PR
[ ] make sure that the 'Allow edits by maintainers' checkbox is checked when creating the PR. Otherwise, the peer reviewer would not be able to push any review changes to the PR and the communication overhead increases
[ ] submit your PR in draft status to run the automated checks and review the results
[ ] in case any checks fail solve the mentioned errors by pushing the corrected code to your PR-branch
[ ] if all checks pass (or if you are unable to resolve the failing steps without any help of the review team), mark the PR as 'ready for review'

Thank you again for your contribution, we will start reviewing your PR as soon as we are able to.

In the meantime, please check our wiki page for creating pull requests and our wiki page for reviewing pull requests for further infomation about our contribution and review process.

@marxjohnson marxjohnson force-pushed the 737-cohort-deletion-bug_main branch from 300c7d5 to 2c40fb8 Compare October 25, 2024 07:34
@marxjohnson
Copy link
Contributor Author

I think the tests were failing due to #734. I have rebased the branch with the fix, so hopefully everything passes now.

@marxjohnson marxjohnson force-pushed the 737-cohort-deletion-bug_main branch from 2c40fb8 to 357edce Compare October 28, 2024 10:19
@marxjohnson marxjohnson force-pushed the 737-cohort-deletion-bug_main branch from 357edce to b9f6ec0 Compare October 28, 2024 14:10
@marxjohnson marxjohnson marked this pull request as ready for review October 29, 2024 08:39
@abias
Copy link
Member

abias commented Oct 31, 2024

Hi @marxjohnson ,

thank you very much for backporting the patch from #739 to the 4.5 stable branch.
This PR seems to have been rebased incorrectly as it contains commits of mine as well.
But don't worry, I will simply close the PR and will backport the patch from main to 4.5 myself afterwards.

Cheers,
Alex

@abias abias closed this Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants