Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REALMC-11689: add arrow functions, typed array fixes, more date-time formats, ... #47

Merged
merged 19 commits into from
Feb 4, 2022
Merged

REALMC-11689: add arrow functions, typed array fixes, more date-time formats, ... #47

merged 19 commits into from
Feb 4, 2022

Conversation

Gabri3l
Copy link

@Gabri3l Gabri3l commented Feb 4, 2022

dop251 and others added 19 commits February 4, 2022 11:57
@dop251 @Gabri3l
Fixed typed arrays' defineProperty and indexing. Fixes dop251#308.
c095cd6 
Signed-off-by: Gabri <[email protected]>
(cherry picked from commit fc7d812)
@mstoykov @Gabri3l
Fix Proxy creation panicing on target not callable
3923f3e 
fixes dop251#306

Signed-off-by: Gabri <[email protected]>
(cherry picked from commit b4db7b1)
@dop251 @Gabri3l
Do not modify sb for variadic calls as it breaks local variables reso…
73539f9 
…lution. Instead place a marker on stack and use it to count the number of args. Fixes dop251#311.

Signed-off-by: Gabri <[email protected]>
(cherry picked from commit c6e1779)
@dop251 @Gabri3l
Support patterns in catch clause. See dop251#305
e10028f 
Signed-off-by: Gabri <[email protected]>
(cherry picked from commit f87bc71)
@dop251 @Gabri3l
Fixed the handling of Symbol properties in destructuring assignments. F…
9cf58f8 
…ixes dop251#312.

Signed-off-by: Gabri <[email protected]>
(cherry picked from commit c8bd2d4)
@dop251 @Gabri3l
Ensure ToPropertyKey happens earlier when assigning computed keys. Fixes
867c110 
 dop251#312.

Signed-off-by: Gabri <[email protected]>
(cherry picked from commit cfff9ec)
@dop251 @Gabri3l
Aligned detached buffer semantics with the latest specs. Fixes dop251…
d374f34 
…#315.

Signed-off-by: Gabri <[email protected]>
(cherry picked from commit cd01c06)
@dop251 @Gabri3l
More typed arrays fixes
23ea7f2 
Signed-off-by: Gabri <[email protected]>
(cherry picked from commit 9cf7f40)
@dop251 @Gabri3l
Fixed accessor and property key function names. Fixes dop251#314.
77c7d64 
Signed-off-by: Gabri <[email protected]>
(cherry picked from commit 67780b8)
@dop251 @Gabri3l
Fixed possible panic when sorting non-standard arrays.
3c275b3 
Signed-off-by: Gabri <[email protected]>
(cherry picked from commit b54ccd1)
@dop251 @Gabri3l
Added nil-safety checks for values returned by get*() methods
1110c7a 
Signed-off-by: Gabri <[email protected]>
(cherry picked from commit ccd9128)
@dop251 @Gabri3l
Fixed panics in parser on some invalid inputs. Fixes dop251#318.
9b4f991 
Signed-off-by: Gabri <[email protected]>
(cherry picked from commit 4fb1f70)
@dop251 @Gabri3l
Arrow function (dop251#319)
44fbc76 
* Implemented arrow functions. See dop251#304.

* Define the name property for anonymous functions (including arrow functions)

* Treat "arguments" as a lexical binding to match the latest specification

Signed-off-by: Gabri <[email protected]>
(cherry picked from commit 9981850)
@dop251 @Gabri3l
Allow arrow functions to contain 'use strict' for simple parameter li…
78b20b6 
…sts. Fixes dop251#323.

Signed-off-by: Gabri <[email protected]>
(cherry picked from commit f2b020d)
@dop251 @Gabri3l
Fixed argument variable reference resolution in stashless functions
a5b4da6 
Signed-off-by: Gabri <[email protected]>
(cherry picked from commit f3b82bd)
@dop251 @Gabri3l
Treat date-only formats as UTC and date-time as local timezone. Added…
e1aedbe 
… support for additional datetime formats. Fixes dop251#281, fixes dop251#292.

Signed-off-by: Gabri <[email protected]>
(cherry picked from commit f605f7b)
@dop251 @Gabri3l
Use correct createArgsRest variant when arguments are not in stash. F…
7cdbcc8 
…ixes dop251#327

Signed-off-by: Gabri <[email protected]>
(cherry picked from commit f08849b)
@dop251 @Gabri3l
Fixed formatting for go 1.17
18cd651 
Signed-off-by: Gabri <[email protected]>
(cherry picked from commit 797091d)
@dop251 @Gabri3l
Report 'length' as own property for Go slices. Fixes dop251#328.
2c4edae 
Signed-off-by: Gabri <[email protected]>
(cherry picked from commit 5513673)
Gabri3l
Gabri3l commented Feb 4, 2022
View reviewed changes
memory_test.go
@@ -25,7 +25,7 @@ func (muc TestNativeMemUsageChecker) NativeMemUsage(value interface{}) (uint64,
func TestMemCheck(t *testing.T) {
// This is the sum of property names allocated at each new (empty) scope
var emptyFunctionScopeOverhead uint64 = 8
var functionStackOverhead uint64 = 30
var functionStackOverhead uint64 = 34
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only change I had to make

@Gabri3l Gabri3l changed the title REALMC-11689: add arrow functions, typed array fixes, moew date-time formats, ... REALMC-11689: add arrow functions, typed array fixes, more date-time formats, ... Feb 4, 2022
@Gabri3l Gabri3l requested review from tsedgwick and arahmanan and removed request for tsedgwick February 4, 2022 18:24
tsedgwick
tsedgwick approved these changes Feb 4, 2022
View reviewed changes
Copy link

@tsedgwick tsedgwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

arahmanan
arahmanan approved these changes Feb 4, 2022
View reviewed changes
Copy link

@arahmanan arahmanan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Just a question, which could be part of a separate ticket/PR since I noticed that some other existing objects such as mapIterObject and setObject don't have a MemUsage function.

func.go
Comment on lines +18 to 35
type baseJsFuncObject struct {
baseFuncObject

stash *stash
prg *Program
src string
stash *stash
prg *Program
src string
strict bool
}

type funcObject struct {
baseJsFuncObject
}

type arrowFuncObject struct {
baseJsFuncObject
this Value
newTarget Value
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[q] should we modify/add the MemUsage function for these objects?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, let me take a look!

Copy link
Author

@Gabri3l Gabri3l Feb 4, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I will create a separate ticket so that I can first try to pull in the remaining changes from goja.

https://jira.mongodb.org/browse/REALMC-11692

@Gabri3l Gabri3l merged commit ecdfff3 into mongodb-forks:realm Feb 4, 2022
@Gabri3l Gabri3l deleted the update_goja_part_2 branch February 4, 2022 20:38
@andrewzlchen andrewzlchen mentioned this pull request Aug 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arahmanan arahmanan arahmanan approved these changes

@tsedgwick tsedgwick tsedgwick approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Gabri3l @tsedgwick @arahmanan @dop251 @mstoykov