Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accessor names being wrong #314

Closed
mstoykov opened this issue Jul 26, 2021 · 0 comments
Closed

Accessor names being wrong #314

mstoykov opened this issue Jul 26, 2021 · 0 comments
Labels
bug

Comments

@mstoykov
Copy link
Contributor

Test test/language/expressions/object/fn-name-accessor-get.js

Fails with:

Expected SameValue(«get id() {}», «get id») to be true

This used to fail with

Expected SameValue(«id», «get id») to be true

Similar problems for

  • test/language/expressions/object/fn-name-accessor-set.js - same but with set instead of get
  • test/language/expressions/object/fn-name-cover.js Test262Error: via anonymous Symbol Expected SameValue(«Symbol()», «») to be true
  • test/language/expressions/object/fn-name-fn.js Test262Error: via anonymous Symbol Expected SameValue(«Symbol()», «») to be true
  • test/language/expressions/object/method-definition/fn-name-fn.js Test262Error: via anonymous Symbol Expected SameValue(«Symbol()», «») to be true
  • test/language/expressions/object/method-definition/name-name-prop-symbol.js Test262Error: via anonymous Symbol Expected SameValue(«Symbol()», «») to be true
@dop251 dop251 closed this as completed in 4c062c2 Jul 29, 2021
@dop251 dop251 added the bug label Jul 29, 2021
@Gabri3l Gabri3l mentioned this issue Feb 4, 2022
Merged
Gabri3l added a commit to mongodb-forks/goja that referenced this issue Feb 4, 2022
@Gabri3l
REALMC-11689: add arrow functions, typed array fixes, more date-time …
ecdfff3 
…formats, ... (#47)

* Fixed typed arrays' defineProperty and indexing. Fixes dop251#308.
* Fix Proxy creation panicing on target not callable
* Do not modify sb for variadic calls as it breaks local variables resolution. Instead place a marker on stack and use it to count the number of args. Fixes dop251#311.
* Support patterns in catch clause. See dop251#305
* Fixed the handling of Symbol properties in destructuring assignments. Fixes dop251#312.
* Ensure ToPropertyKey happens earlier when assigning computed keys. Fixes dop251#312.
* Aligned detached buffer semantics with the latest specs. Fixes dop251#315.
* More typed arrays fixes
* Fixed accessor and property key function names. Fixes dop251#314.
* Fixed possible panic when sorting non-standard arrays.
* Added nil-safety checks for values returned by get*() methods
* Fixed panics in parser on some invalid inputs. Fixes dop251#318.
* Arrow function (dop251#319)
* Implemented arrow functions. See dop251#304.
* Define the name property for anonymous functions (including arrow functions)
* Treat "arguments" as a lexical binding to match the latest specification
* Allow arrow functions to contain 'use strict' for simple parameter lists. Fixes dop251#323.
* Fixed argument variable reference resolution in stashless functions
* Treat date-only formats as UTC and date-time as local timezone. Added support for additional datetime formats. Fixes dop251#281, fixes dop251#292.
* Use correct createArgsRest variant when arguments are not in stash. Fixes dop251#327
* Fixed formatting for go 1.17
* Report 'length' as own property for Go slices. Fixes dop251#328.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mstoykov @dop251