Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

About the "Date" problem in JS script #281

Closed
iveryo opened this issue Apr 17, 2021 · 2 comments
Closed

About the "Date" problem in JS script #281

iveryo opened this issue Apr 17, 2021 · 2 comments

Comments

@iveryo
Copy link

iveryo commented Apr 17, 2021

Such as:
new Date("2021-04-18 23:59:59").getTime()
The result returned after the script is run is: 1618790399000
My expectation is: 1618761599000
Is it a bug? Thank you

@dop251
Copy link
Owner

dop251 commented Apr 20, 2021

Hi. Strictly speaking no, it's not a bug. The specification only requires to support YYYY-MM-DDTHH:mm:ss.sssZ, anything else is left up to implementations, which means any code that relies on it is not portable. For instance in Safari 14.0.3 yor code returns NaN.

I found a mentioning in the MDN docs here that "when the time zone offset is absent, date-only forms are interpreted as a UTC time and date-time forms are interpreted as local time". It's non-standard though. I might look at it at some point, but it's not a priority right now.

@iveryo
Copy link
Author

iveryo commented Apr 20, 2021

Okay thank you

@dop251 dop251 closed this as completed in 6338b32 Sep 4, 2021
Gabri3l added a commit to mongodb-forks/goja that referenced this issue Feb 4, 2022
…formats, ... (#47)

* Fixed typed arrays' defineProperty and indexing. Fixes dop251#308.
* Fix Proxy creation panicing on target not callable
* Do not modify sb for variadic calls as it breaks local variables resolution. Instead place a marker on stack and use it to count the number of args. Fixes dop251#311.
* Support patterns in catch clause. See dop251#305
* Fixed the handling of Symbol properties in destructuring assignments. Fixes dop251#312.
* Ensure ToPropertyKey happens earlier when assigning computed keys. Fixes dop251#312.
* Aligned detached buffer semantics with the latest specs. Fixes dop251#315.
* More typed arrays fixes
* Fixed accessor and property key function names. Fixes dop251#314.
* Fixed possible panic when sorting non-standard arrays.
* Added nil-safety checks for values returned by get*() methods
* Fixed panics in parser on some invalid inputs. Fixes dop251#318.
* Arrow function (dop251#319)
* Implemented arrow functions. See dop251#304.
* Define the name property for anonymous functions (including arrow functions)
* Treat "arguments" as a lexical binding to match the latest specification
* Allow arrow functions to contain 'use strict' for simple parameter lists. Fixes dop251#323.
* Fixed argument variable reference resolution in stashless functions
* Treat date-only formats as UTC and date-time as local timezone. Added support for additional datetime formats. Fixes dop251#281, fixes dop251#292.
* Use correct createArgsRest variant when arguments are not in stash. Fixes dop251#327
* Fixed formatting for go 1.17
* Report 'length' as own property for Go slices. Fixes dop251#328.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants