Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proxy creation panics on target not callable #306

Closed
mstoykov opened this issue Jul 22, 2021 · 2 comments · Fixed by #307
Closed

Proxy creation panics on target not callable #306

mstoykov opened this issue Jul 22, 2021 · 2 comments · Fixed by #307

Comments

@mstoykov
Copy link
Contributor

The following tc39 test panics which unfortunately is from after the current commit used in goja :(
mstoykov added a commit to mstoykov/goja that referenced this issue Jul 22, 2021
@mstoykov
Fix Proxy creation panicing on target not callable
6e2dd7d 
fixes dop251#306
@mstoykov mstoykov mentioned this issue Jul 22, 2021
Merged
@dop251
Copy link
Owner

dop251 commented Jul 22, 2021

Are you sure this is the right test? I can see it and it passes.

@dop251
Copy link
Owner

dop251 commented Jul 22, 2021

Ok, got it, the test I have is slightly different (p.call() vs. p())

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix Proxy creation panicing on target not callable mstoykov/goja
2 participants
@mstoykov @dop251