New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Proxy creation panicing on target not callable #307

Merged

dop251 merged 1 commit into dop251:master from mstoykov:fixProxyPanic

Jul 22, 2021

Contributor

mstoykov commented Jul 22, 2021

fixes #306


          Fix Proxy creation panicing on target not callable

6e2dd7d

fixes dop251#306

mstoykov commented

View reviewed changes

proxy.go

               func (p *proxyObject) apply(call FunctionCall) Value {
               	if p.call == nil {
-              		p.val.runtime.NewTypeError("proxy target is not a function")
+              		panic(p.val.runtime.NewTypeError("proxy target is not a function"))

Contributor Author

mstoykov Jul 22, 2021

I didn't find another occurrence of this in the code

dop251 merged commit c206830 into dop251:master

mstoykov deleted the fixProxyPanic branch

July 22, 2021 12:53

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet