use set_montage for mff and egi #6511
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6511 +/- ##
=========================================
- Coverage 89.26% 87.9% -1.37%
=========================================
Files 413 413
Lines 74603 74619 +16
Branches 12302 12304 +2
=========================================
- Hits 66598 65594 -1004
- Misses 5158 6187 +1029
+ Partials 2847 2838 -9 |
|
Azure is falling due to a deprecation error (see #6514). We can still merge as it is. |
|
ok to merge this one @massich ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
let me know what you think @massich
feel free to take over.
once you remove the last call to _check_update_montage
please remove this function from the code base.