NICOLET: use set_montage at the end of the __init__ #6497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
agramfort
reviewed
Jun 26, 2019
mne/io/nicolet/nicolet.py
Outdated
| @@ -171,11 +171,12 @@ def __init__(self, input_fname, ch_type, montage=None, eog=(), ecg=(), | |||
| info, header_info = _get_nicolet_info(input_fname, ch_type, eog, ecg, | |||
| emg, misc) | |||
| last_samps = [header_info['num_samples'] - 1] | |||
| _check_update_montage(info, montage) | |||
| # _check_update_montage(info, montage) | |||
There was a problem hiding this comment.
Suggested change
| # _check_update_montage(info, montage) |
agramfort
approved these changes
Jun 26, 2019
Codecov Report
@@ Coverage Diff @@
## master #6497 +/- ##
==========================================
+ Coverage 89.25% 89.26% +<.01%
==========================================
Files 413 413
Lines 74542 74557 +15
Branches 12296 12296
==========================================
+ Hits 66530 66550 +20
+ Misses 5158 5157 -1
+ Partials 2854 2850 -4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is part of #6461. The concrete goal here is to make sure that:
1 - RawNicolet is always called with montage=None
2 - ensure self.set_montage(montage) is called at the end of init