Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MNT: use self.set_montage at the end of EpochsEEGLAB.__init__ #6496

Merged
merged 1 commit into from
Jun 26, 2019
Merged

MNT: use self.set_montage at the end of EpochsEEGLAB.__init__ #6496

merged 1 commit into from
Jun 26, 2019

Conversation

massich
Copy link
Contributor

@massich massich commented Jun 26, 2019

No description provided.

@massich
Copy link
Contributor Author

massich commented Jun 26, 2019

It is green in my machine

larsoner
larsoner approved these changes Jun 26, 2019
View reviewed changes
Copy link
Member

@larsoner larsoner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to merge when green

@codecov
Copy link

codecov bot commented Jun 26, 2019

Codecov Report

Merging #6496 into master will increase coverage by 0.3%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master    #6496     +/-   ##
=========================================
+ Coverage   89.23%   89.53%   +0.3%     
=========================================
  Files         413      413             
  Lines       74532    76036   +1504     
  Branches    12300    13105    +805     
=========================================
+ Hits        66509    68081   +1572     
+ Misses       5165     5119     -46     
+ Partials     2858     2836     -22

@larsoner larsoner merged commit 4939f51 into mne-tools:master Jun 26, 2019
@massich massich mentioned this pull request Jul 2, 2019
Merged
massich added a commit that referenced this pull request Jul 3, 2019
@massich
MNT, TST: refactor read_raw_FOO set_montage test (#6521)
dd54d3c 
This PR refactors into a single test all the testing introduced by the following PRs:

#6511, #6513, #6497, #6496, #6480, #6469, #6471, #6476
@massich massich deleted the epochsEEGLAB_montage branch July 3, 2019 11:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larsoner larsoner larsoner approved these changes

@agramfort agramfort Awaiting requested review from agramfort

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@massich @larsoner