Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cnt: use set_montage at the end of the __init__ #6471

Merged
merged 2 commits into from
Jun 21, 2019

Conversation

massich
Copy link
Contributor

@massich massich commented Jun 19, 2019

This PR is part of #6461. The concrete goal here is to make sure that:
1 - RawCNT is always called with montage=None
2 - ensure self.set_montage(montage) is called at the end of init

@massich massich changed the title cnt: use set_montage at the end of the __init__ #6469 cnt: use set_montage at the end of the __init__ Jun 19, 2019
@codecov
Copy link

codecov bot commented Jun 19, 2019

Codecov Report

Merging #6471 into master will increase coverage by 0.03%.
The diff coverage is 90.9%.

@@            Coverage Diff             @@
##           master    #6471      +/-   ##
==========================================
+ Coverage   89.21%   89.25%   +0.03%     
==========================================
  Files         413      413              
  Lines       74286    74338      +52     
  Branches    12277    12282       +5     
==========================================
+ Hits        66277    66348      +71     
+ Misses       5148     5134      -14     
+ Partials     2861     2856       -5

@larsoner
Copy link
Member

I don't know of any CNT montage. You can just create one from scratch using the correct ch_names and np.random.randn(n_chs, 3) if you want.

@agramfort agramfort marked this pull request as ready for review June 21, 2019 08:32
@agramfort agramfort merged commit 352d3f0 into mne-tools:master Jun 21, 2019
@agramfort
Copy link
Member

thx @massich

@massich massich deleted the cnt_montage branch June 25, 2019 19:28
massich added a commit that referenced this pull request Jul 3, 2019
This PR refactors into a single test all the testing introduced by the following PRs:

#6511, #6513, #6497, #6496, #6480, #6469, #6471, #6476
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants