Update 2.2 keyboard mapping template #1950
Conversation
…``Show Samplers``.
… with the ``--developer`` argument. If these shortcuts are not explicitly listed in other languages mappings, they are not visible to the user (replaced by question mark).
…e``, and ``fwd``. These controls do not have a representation in the UI anymore, replaced by the beatjump controls. Now the keyboard user is more flexible, and the shortcuts work depending on the value of the beatjump- selector in the UI. Visual feedback by the beatjump buttons.
…o the buttons in the UI.
…s in the UI. Not sure about the ``loop_halve`` and ``loop_double`` controls, need feedback.
|
Thank you for adopting this. LGTM so far. |
|
The mappings were changed using the macOS on-screen keyboard. Will update the keyboard mapping table/image in the manual afterwards. |
| loop_halve w | ||
| beatjump_forward Shift+w |
There was a problem hiding this comment.
Oops, beatjump_forward and beatjump_backward are assigned twice.
I would like to use the vacant Shift+w and Shift+i shortcuts to scale the beatjump_size inside the spinbox. Does this even work with the keyboard? beatjump_size_up and beatjump_size_downdo not work...
It works with loop_halve and loop_double for the beatloop_size, and it would be nice to have something similar for beatjump_size
|
Shouldn't we re-target this to 2.3.0? Changing the mappings and user experience with a bugfix release doesn't seem to be appropriate, even if it is an improvement. Sorry, I've never used the keyboard mappings, so I might be the wrong person for reviewing the actual contents of this PR. |
|
Re-targeted to master |
|
What's the state here? |
|
cross linking launchpad report: https://bugs.launchpad.net/mixxx/+bug/1826724 |
|
polite ping @esbrandt is something missing here? |
|
@foss- No plans to add any further feature for now, so removing the [WIP] tag. |
esbrandt
changed the title
|
Thank you. |
|
r6875 A/S J/K beat jump keys not working. Shift+key works for jump one beat but not normal press for X beats. Built on Linux Manjaro x64. |
|
@kazakore: since this PR is already merged, I am afraid you report will be lost. |
… was due to double entries for beatjump controls, that slipped in in a previous commit. https://bugs.launchpad.net/mixxx/+bug/1837554 Follow-up to mixxxdj#1950
The updated mapping makes use of the recent controls without changing the base functionality much.
Once the
en_USmapping is approved, I`ll update the mapping for the other languages too.