-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
replace Flanger with QuickEffect,enable in keyboard mappings #2233
Conversation
Thanks for taking care of this long outstanding issue! I think it is not a good idea to rush it into the 2.2.2 release now that the release process is almost finished. We also need to update the manual. Therefore I propose to schedule this fix for milestone 2.2.x/2.2.3. |
done. |
Please rebase on 2.2 and then cherry-pick this commit: Last chance to include this in 2.2.2. @daschuer @ywwg @esbrandt Who is entitled to merge the 2 pending PRs for the manual? I will wait with merging this PR until the manual has been updated. |
@@ -11,13 +11,13 @@ | |||
xmlns:sodipodi="http://sodipodi.sourceforge.net/DTD/sodipodi-0.dtd" | |||
xmlns:inkscape="http://www.inkscape.org/namespaces/inkscape" | |||
sodipodi:docname="ic_template_keyboard_mapping_sheet.svg" | |||
inkscape:version="0.48.2 r9819" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file still references "Mixxx 1.11" multiple times. Could you please update this to "Mixxx 2.2"? Maybe we should remove the version numbers entirely, otherwise we forget to update them with every new version.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I removed the version numbers.
Also, I resized the SVG to ease PNG export by simply selecting "Entire Page" and exporting to 1280px width
This is in master for a while. It was originally targeted for 2.2, but later re-targeted to 2.3 by request. |
right. must have mixed it up with the manual PR. The manual image template res/images/templates/ic_template_keyboard_mapping_sheet.svg can go to master now, or later. |
I will now rebase and merge this commit, including the old version of the manual. There are 3 open PRs for the manual. Unfortunately I failed to build the PDF version with pdflatex locally, so the outdated version will be bundled with the release packages. |
I also fixed a whitespace issue in depends.py that only affects SCons 3 / Python 3. |
@ronso0: Could you please check if all your commits are available in 2.2 now? GitHub doesn't seem to be able to detect that after I've done the rebase and merge locally. Then we can close this PR manually. |
Yep, looks good! |
direct Flanger controls are deprecated for a while now.
replaced those with with
[QuickEffectRack1_[Channel1]_Effect1],enabled
should go to master, as well