Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS keyboard shortcuts for fullscreen not shown / working #9645

Closed
mixxxbot opened this issue Aug 23, 2022 · 18 comments
Closed

macOS keyboard shortcuts for fullscreen not shown / working #9645

mixxxbot opened this issue Aug 23, 2022 · 18 comments

Comments

@mixxxbot
Copy link
Collaborator

Reported by: foss-4
Date: 2019-04-28T11:02:25Z
Status: Fix Released
Importance: Low
Launchpad Issue: lp1826724
Tags: usability
Attachments: [fullscreen and skin prefs keyboard shortut missing.jpg](https://bugs.launchpad.net/bugs/1826724/+attachment/5259652/+files/fullscreen and skin prefs keyboard shortut missing.jpg), [options > keyboard shortcuts.jpg](https://bugs.launchpad.net/bugs/1826724/+attachment/5259653/+files/options > keyboard shortcuts.jpg), [skin pref shortcut still missing.png](https://bugs.launchpad.net/bugs/1826724/+attachment/5288879/+files/skin pref shortcut still missing.png), [Capture 2019-09-16_05-50-55_AM.png](https://bugs.launchpad.net/bugs/1826724/+attachment/5288910/+files/Capture 2019-09-16_05-50-55_AM.png)


macOS 10.13.6
mixxx 2.2.1 (build 2.2 r6690)
german locale

this has not started with 2.2.1, I only now got around to file this.

the keyboard shortcuts for fullscreen and skin preferences are not shown or working.

options > keyboard shortcuts is also affected

see screenshots

@mixxxbot
Copy link
Collaborator Author

Commented by: foss-4
Date: 2019-04-28T11:02:25Z
Attachments: [fullscreen and skin prefs keyboard shortut missing.jpg](https://bugs.launchpad.net/mixxx/+bug/1826724/+attachment/5259652/+files/fullscreen and skin prefs keyboard shortut missing.jpg)

@mixxxbot
Copy link
Collaborator Author

Commented by: foss-4
Date: 2019-04-28T11:02:40Z
Attachments: [options > keyboard shortcuts.jpg](https://bugs.launchpad.net/mixxx/+bug/1826724/+attachment/5259653/+files/options > keyboard shortcuts.jpg)

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2019-04-28T11:14:05Z


#1950

@mixxxbot
Copy link
Collaborator Author

Commented by: foss-4
Date: 2019-07-07T11:39:10Z


#1950 merged
Also related:
#2178

@mixxxbot
Copy link
Collaborator Author

Commented by: Be-ing
Date: 2019-09-14T18:08:14Z


Is this fixed now that #2178 has been merged?

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2019-09-15T17:25:51Z


Fixed with macOS 10.14.6 (18G95) and Mixxx 2.3.0-alpha-pre (build master r6938)

@mixxxbot
Copy link
Collaborator Author

Commented by: foss-4
Date: 2019-09-15T23:06:56Z
Attachments: [skin pref shortcut still missing.png](https://bugs.launchpad.net/mixxx/+bug/1826724/+attachment/5288879/+files/skin pref shortcut still missing.png)


Hi @jus
the shortcut for skin preferences is not shown. Is that working for you? Tested w macOS 10.14.6 + mixxx 2.3.0 (r6938)

@mixxxbot
Copy link
Collaborator Author

Commented by: foss-4
Date: 2019-09-15T23:13:13Z


or we can file a new bug for this remaining problem.

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2019-09-16T04:03:39Z
Attachments: [Capture 2019-09-16_05-50-55_AM.png](https://bugs.launchpad.net/mixxx/+bug/1826724/+attachment/5288910/+files/Capture 2019-09-16_05-50-55_AM.png)


Works for me, strange.
Any custom Mixxx keyboard configuration on your side?

When starting with./mixxx --developer
check the log for

``Debug [Main]: Found and will use default keyboard preset``
and
``Debug [Main]: Loading translations for locale``

Make sure the lines read de_DE.kbd.cfg and de respectively.

@mixxxbot
Copy link
Collaborator Author

Commented by: foss-4
Date: 2019-09-16T08:08:57Z


Language is set to "System".

Tried switching to german, but the issue was the same so assuming mixxx is correctly using german as system locale.

What exact terminal command are you using to start mixxx in developer mode?

@mixxxbot
Copy link
Collaborator Author

Commented by: foss-4
Date: 2019-09-16T08:26:36Z


when switching to english, the keybaord shortcut cmd 1 does show as expected

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2019-09-16T10:20:04Z


What exact terminal command are you using to start mixxx in developer mode?

https://mixxx.org/manual/2.3/en/chapters/appendix.html#developer-tools

@mixxxbot
Copy link
Collaborator Author

Commented by: foss-4
Date: 2019-09-16T14:01:48Z


./mixxx --controllerDebug --developer --resourcePath res
-bash: ./mixxx: No such file or directory

hm. so for you with german locale the keyboard shortcut shows fine? wonder how our systems differ...

@mixxxbot
Copy link
Collaborator Author

Commented by: foss-4
Date: 2019-09-16T14:01:58Z


btw you are not on zulip are you?

@mixxxbot
Copy link
Collaborator Author

Commented by: esbrandt
Date: 2019-09-16T17:27:18Z


< -bash: ./mixxx: No such file or directory

You can start from within the git folder, given you are building from source.

If you are using the app from the build server, you need to point to the correct path inside the application folder. e.g. /Applications/Mixxx.app/Contents/MacOS/Mixxx --controllerDebug --developer

@mixxxbot
Copy link
Collaborator Author

Commented by: foss-4
Date: 2019-09-17T19:12:05Z


Done (starting from terminal)

Checked log for
Debug [Main]: Found and will use default keyboard preset
Result:
Debug [Main]: Found and will use default keyboard preset "/Applications/Mixxx.app/Contents/Resources/keyboard/de_DE.kbd.cfg"

Checked log for
Debug [Main]: Loading translations for locale
Result:
Debug [Main]: Loading translations for locale "de_DE" from translations folder "/Applications/Mixxx.app/Contents/Resources/translations/" : success

@mixxxbot
Copy link
Collaborator Author

Commented by: foss-4
Date: 2019-11-10T13:54:41Z


As this bug is set to "fix committed" and the fix indeed solves the problem with fullscreen keyboard shortcut now showing correctly and working, decided to file a new bug for the remaining issue with skin preferences keyboard shortcut still missing to have a clean start and close this existing bug.

https://bugs.launchpad.net/mixxx/+bug/1851993

@mixxxbot
Copy link
Collaborator Author

Issue closed with status Fix Released.

@mixxxbot mixxxbot transferred this issue from another repository Aug 24, 2022
@mixxxbot mixxxbot added this to the 2.3.0 milestone Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant