Fix beatjump keyboard mapping controls not working reliable. This…
#2256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… was due to double entries for beatjump controls, that slipped in in a previous commit. https://bugs.launchpad.net/mixxx/+bug/1837554 Follow-up to mixxxdj#1950
|
Thank you. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… was due to double entries for beatjump controls, that slipped in in a previous commit.
https://bugs.launchpad.net/mixxx/+bug/1837554
Follow-up to #1950
This slipped in by accident. Originally my ( unsuccessful ) attempt was to assign
beatjump_sizeto the now deleted controls. If you come up with an idea to mapbeatjump_size, so we can scale the size up/down similar toloop_halveorloop_double, it would be nice to have.