This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: changed styling of archive button * feat: added focus state * feat: refactored code * feat: renamed to StyledButton, removed redundant props and sorted * feat: changed focus color to theme color * feat: added interface and focus on hover * feat: removed transition Co-authored-by: VWSCoronaDashboard21 <[email protected]>
* feat: changed borderColor of measure tile * feat: refactored code based on code conventions Co-authored-by: VWSCoronaDashboard21 <[email protected]>
…#4510) * bugfix(COR-1067): Adjust icon button styled component to align with new conventions. * bugfix(COR-1067): Adjust the close button positioning, update code according to conventions. * bugfix(COR-1067): PR feedback * bugfix(COR-1067): PR feedback
…the ID anchor element is vertically centered relative to the title of the collapsible; rewrote the CollapsibleSection component to leverage updated conventions; (#4517) Co-authored-by: VWSCoronaDashboard26 <[email protected]>
Co-authored-by: VWSCoronaDashboard21 <[email protected]>
…hor elements underlined when associated props are supplied; rewrote (parts of) the styled component; (#4516) Co-authored-by: VWSCoronaDashboard26 <[email protected]>
- Update documentation for new code conventions - Reorder the Code Conventions part of the document, because of it growth
* updated TooltipContent component so that the entire tooltip becomes a clickable anchor element if a link is supplied, but remains a div element when no link is present; * rewrote the TooltipContent component to leverage/satisfy updated conventions; Co-authored-by: VWSCoronaDashboard26 <[email protected]>
* feat: applied a new button design * fix: resolved conversation * fix: resolved conversation * fix: fixing styling of the button outline * fix: fixing styling of the button outline Co-authored-by: VWSCoronaDashboard27 <[email protected]>
* fix: tooltip max-width to 440px * fix: partly changed styled system to styled components * fix: wip styled components * fix: changed StyledTriangleWrapper styled component * fix: changed all styled system to styled components Co-authored-by: VWSCoronaDashboard21 <[email protected]>
* feat(COR-1149): Added border logic for outside borders and applied drop-shadow * feat(COR-1149): Implements same design for tabstate as hover. Attempts to fix bug related to waterbodies in Zeeland. * feat(COR-1149): Added a comment. * Update packages/app/src/components/choropleth/components/canvas-choropleth-map.tsx * feat(choropleth): PR feedback adjustments Co-authored-by: VWSCoronaDashboard18 <[email protected]>
* feat(theme-tiles): Adds a new field to select the intensity for the trend icon. * feat(theme-tiles): Adds a new field to the topical structure query and changes double quotes to single quotes. * feat(KPI-tiles): Adjusts the trend icon component to render out a new icon for the homepage which takes intensity level into consideration. Co-authored-by: VWSCoronaDashboard26 [email protected] * feat(KPI-tiles): Updates component name, adjusts styling, adds a comment. * feat(KPI-tiles): PR feedback: Added a comment, refactored styling, changed sanity labels. * feat(KPI-tiles): Remove no stroke comment and remove stroke property from intensity level 3.
VWSCoronaDashboard26
requested review from
Jorrik-Klijnsma-Work,
Amber-Taal-Work,
VWSCoronaDashboard25,
DariaKwork and
APW26
December 8, 2022 09:22
APW26
reviewed
Dec 8, 2022
APW26
approved these changes
Dec 8, 2022
VWSCoronaDashboard25
approved these changes
Dec 8, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This release includes the following pull requests: