This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
bugfix/COR-1069-inconsistent-link-hover-styles #4516
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VWSCoronaDashboard26
requested review from
hasan-ozaynaci,
VWSCoronaDashboard25 and
APW26
…hor elements underlined when associated props are supplied; rewrote (parts of) the styled component;
VWSCoronaDashboard26
force-pushed
the
bugfix/COR-1069-inconsistent-link-hover-styles
branch
from
5357709 to
0a6fb0f
Compare
APW26
approved these changes
Nov 29, 2022
hasan-ozaynaci
approved these changes
Nov 29, 2022
VWSCoronaDashboard26
deleted the
bugfix/COR-1069-inconsistent-link-hover-styles
branch
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Notes
The original pull request for bugfix can be found here, yet I opted to close it as it gave the wrong impression about the bug and took a wrong approach to resolve it.
I left a question in said pull request to try and figure out why certain logic was applied to JSX, resulting in complex JSX and a large redundancy of
spanelements in the DOM. However, during testing I realised that these changes were there because of certain sentences being cut off and the fact that we need to group the last word and the arrow icon together. I do still think that this logic should be removed, yet I opted to not pick it up as part of this ticket, mainly due to the fact that this type of logic can be found in multiple places throughout the code base and does not result in inconsistent link styles.As per agreement with design: all links should get an underline when hovered. The below screenshot only covers the link mentioned in the associated ticket, but all links have been checked. Other links that are covered by this pull request are
Links that already existed but have a distinct
text-decorationvalue ofnonehave been left out for now.As mentioned above: there are some more things to generally fix for the various flavours of links, but I think it makes sense pick this up seperately.
Screenshots
Both screenshots show a hover state, but no cursor.
Before
After