bugfix/COR-1069-inconsistent-link-hover-styles

[VWSCoronaDashboard26]

Summary

• updated LinkWithIcon and HeadingLinkWithIcon components to be more generic and prevent faulty hover states

Notes

These changes are based upon the design proposals and work done as part of COR-937, for which the earlier pull request can be found here.
I clicked through the entire dashboard looking for any instances of LinkWithIcon and HeadingLinkWithIcon to be sure that the simplified changes did not introduce any issues and meet the requirements specified.

Screenshots

Both screenshots show a hover state, but no cursor.

Before

After

[VWSCoronaDashboard26]

Perhaps someone could elaborate on this functionality and why it was written like this initially? I do not understand why we would

• split all words only to correctly place the icon after the last word?
• adjust positioning of the icon based on whether there is only a single word or not?
• only use this logic when the iconPlacement evaluates to right, and not also left?

I removed all this logic as I personally did not see any differences between the before and after versions of this component, and I feel my new solution is more straightforward and simple.

[APW26]

I cannot think of why this would have been done this way in the past 🤷

[APW26]

Correct me if im wrong, but from your 'After' screenshot, I understand that the entire link should not be underlined when hovering? 🤔

[APW26]

I cannot think of why this would have been done this way in the past 🤷

[VWSCoronaDashboard26]

Correct me if im wrong, but from your 'After' screenshot, I understand that the entire link should not be underlined when hovering? 🤔

Good question! As discussed, I followed the requirements mentioned in the older COR-937 ticket. To reiterate: this link is not part of a paragraph and should therefore not contain an underline in either its normal or hover states, nor is it a link to a specific single article and should therefore not be bold.