This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 45
Feature/COR-1178: Change trend icons kpi tile #4527
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d changes double quotes to single quotes.
… icon for the homepage which takes intensity level into consideration. Co-authored-by: VWSCoronaDashboard26 [email protected]
APW26
requested review from
Jorrik-Klijnsma-Work,
Amber-Taal-Work and
VWSCoronaDashboard25
December 6, 2022 08:54
…anged sanity labels.
APW26
commented
Dec 6, 2022
VWSCoronaDashboard26
approved these changes
Dec 6, 2022
…from intensity level 3.
Jorrik-Klijnsma-Work
approved these changes
Dec 6, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
DariaKwork
reviewed
Dec 6, 2022
Amber-Taal-Work
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR implements changes as described in COR-1178. The focal point of the changes is the introduction of a new trend icon for the theme tiles (KPI tiles) on the homepage. The new icons represent the intensity of a change in a measurement. To achieve this, a new sanity field has also been created to allow content managers to select an intensity level, along with the colour and direction, which was already possible.
Before:
After: