This repository has been archived by the owner on Nov 4, 2024. It is now read-only.
Feature/COR-1088-archive-button-styling #4508
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Amber-Taal-Work
requested review from
VWSCoronaDashboard26 and
hasan-ozaynaci
Amber-Taal-Work
changed the title
Amber-Taal-Work
changed the title
packages/app/src/components/page-information-block/page-information-block.tsx
Outdated
Show resolved
Hide resolved
packages/app/src/components/page-information-block/page-information-block.tsx
Outdated
Show resolved
Hide resolved
packages/app/src/components/page-information-block/page-information-block.tsx
Outdated
Show resolved
Hide resolved
VWSCoronaDashboard26
approved these changes
Nov 23, 2022
packages/app/src/components/page-information-block/page-information-block.tsx
Outdated
Show resolved
Hide resolved
hasan-ozaynaci
approved these changes
Nov 23, 2022
|
Is the keyboard focus state visible for the light-blue and the dark-blue button? Because I can’t see it in the “after” screenshot. |
APW26
reviewed
Nov 23, 2022
packages/app/src/components/page-information-block/page-information-block.tsx
Outdated
Show resolved
Hide resolved
DariaKwork
approved these changes
Nov 24, 2022
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR addresses the changes described in COR-1088.
In this PR, the styling of the archived graphs button has been changed.
Before
Default state
Active state
Active state on focus
After:
Default state
Default state on hover
Default state on focus
Default state on hover with focus
Active state
Active state on hover
Active state on focus
Active state on hover with focus
