Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix osx baseline build failures #9726

Merged
merged 7 commits into from
Jan 21, 2020
Merged

Fix osx baseline build failures #9726

merged 7 commits into from
Jan 21, 2020

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Jan 17, 2020 •
edited
Loading

  • xerces-c: update ref and sha512
  • sfml: fake error
  • boost-signals: fake error
  • tmxparser: fake error
  • soil2: switch repo to github
  • pcl: fake error
  • gtest: fake error

@JackBoosY JackBoosY added the info:internal This PR or Issue was filed by the vcpkg team. label Jan 17, 2020
This was referenced Jan 17, 2020
Merged
Closed
This was referenced Jan 17, 2020
Merged
Merged
@JackBoosY JackBoosY marked this pull request as ready for review January 17, 2020 08:05
PhoebeHui
PhoebeHui approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@PhoebeHui PhoebeHui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jwillemsen jwillemsen mentioned this pull request Jan 17, 2020
Merged
@JackBoosY JackBoosY mentioned this pull request Jan 17, 2020
Closed
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jan 17, 2020
@PhoebeHui PhoebeHui mentioned this pull request Jan 17, 2020
Merged
@PhoebeHui
Copy link
Contributor

PhoebeHui commented Jan 19, 2020 •
edited
Loading

@vicroms, please priory to review and merge this PR, it blocked many PRs on OSX, thanks!

@PhoebeHui
Copy link
Contributor

Please ignore my above comments, it looks these issue solved on OSX CI testing, I will rerun related PRs.

@jwillemsen
Copy link
Contributor

Any plans to merge this PR? All checks are ok, the changes are required for other PRs that now have all kinds of OSX failures

@strega-nil strega-nil merged commit 8a721c2 into microsoft:master Jan 21, 2020
@strega-nil
Copy link
Contributor

thanks @JackBoosY 😄

@JackBoosY JackBoosY deleted the dev/jack/fix-osx-build-failures branch January 22, 2020 02:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PhoebeHui PhoebeHui PhoebeHui approved these changes

Assignees

@strega-nil strega-nil

@vicroms vicroms

@PhoebeHui PhoebeHui

Labels
info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@JackBoosY @PhoebeHui @jwillemsen @strega-nil @vicroms