Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMake tool version to 3.16.2 on Windows, Linux, MacOS #9531

Closed
wants to merge 2 commits into from

Conversation

mbeutel
Copy link
Contributor

@mbeutel mbeutel commented Jan 2, 2020

This PR updates the version of the CMake instance used by Vcpkg to build packages.

  • What does your PR fix? Libraries that require CMake 3.15 or CMake 3.16 cannot currently be built with Vcpkg unless a custom CMake version is supplied because Vcpkg pulls an outdated version of CMake.

  • Which triplets are supported/not supported? Have you updated the CI baseline? does not apply

  • Does your PR follow the maintainer guide? yes

@qis
Copy link
Contributor

qis commented Jan 3, 2020

Isn't the vcpkg cmake version supposed to be the same as the one that ships with the latest Visual Studio release?

Otherwise, why 3.16.2 instead of 3.16.0? Those are mostly bugfixes that don't affect vcpkg targets.

@JackBoosY
Copy link
Contributor

Related: #7801

@mbeutel
Copy link
Contributor Author

mbeutel commented Jan 3, 2020

@qis I didn't find anything about CMake version policy in the maintainer guide. I chose CMake 3.16.2 because it's the latest and greatest, and because I'd really like to rely on some new features (MSVC_RUNTIME_LIBRARY semantics in CMake 3.15, precompiled headers in 3.16) in my libraries.

I'm surprised by the number of port breakages though.

@NancyLi1013
Copy link
Contributor

/azp run

@cbezault
Copy link
Contributor

@mbeutel to be honest most if not all the failures look spurious.

@mbeutel mbeutel force-pushed the feature/cmake-3.16 branch from 97026e0 to 6c07703 Compare January 17, 2020 09:05
@mbeutel
Copy link
Contributor Author

mbeutel commented Jan 17, 2020

@mbeutel to be honest most if not all the failures look spurious.

What does that mean? Browsing through the build logs, I couldn't spot anything that seemed directly related to CMake; but what else would have caused these errors? One of these packages already failed in the commit on which I had branched, but several others apparently were fine.

Anyway, I just rebased this PR on top of current master, so perhaps some of the failures will now go away.

@mbeutel
Copy link
Contributor Author

mbeutel commented Jan 17, 2020

And the MacOS pipeline already failed. That indeed looks spurious :(

@JackBoosY
Copy link
Contributor

@mbeutel OSX build failures will resolved in #9726.

@NancyLi1013
Copy link
Contributor

/azp run

@cbezault
Copy link
Contributor

@mbeutel thanks for being a sport and fixing things that have nothing to do with your change.

@mbeutel
Copy link
Contributor Author

mbeutel commented Jan 23, 2020

@cbezault not sure which fixes you are referring to? Unfortunately I didn't have the time to work on the fallout yet. I plan to do so because not having CMake 3.16 in Vcpkg is holding me back, but I don't know when I'll have time for it.

@vicroms
Copy link
Member

vicroms commented Jan 28, 2020

/azp run

@JackBoosY JackBoosY added the wip label Feb 1, 2020
@NancyLi1013
Copy link
Contributor

/azp run

@JackBoosY
Copy link
Contributor

@mbeutel I opened a new PR #10767 to update cmake to a newer version.

@JackBoosY
Copy link
Contributor

Closing this PR since it seems that no progress is being made. Please reopen if work is still being done.

@JackBoosY JackBoosY closed this May 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants