-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update CMake tool version to 3.16.2 on Windows, Linux, MacOS #9531
Conversation
Isn't the vcpkg cmake version supposed to be the same as the one that ships with the latest Visual Studio release? Otherwise, why 3.16.2 instead of 3.16.0? Those are mostly bugfixes that don't affect vcpkg targets. |
Related: #7801 |
@qis I didn't find anything about CMake version policy in the maintainer guide. I chose CMake 3.16.2 because it's the latest and greatest, and because I'd really like to rely on some new features ( I'm surprised by the number of port breakages though. |
/azp run |
@mbeutel to be honest most if not all the failures look spurious. |
97026e0
to
6c07703
Compare
What does that mean? Browsing through the build logs, I couldn't spot anything that seemed directly related to CMake; but what else would have caused these errors? One of these packages already failed in the commit on which I had branched, but several others apparently were fine. Anyway, I just rebased this PR on top of current master, so perhaps some of the failures will now go away. |
And the MacOS pipeline already failed. That indeed looks spurious :( |
/azp run |
@mbeutel thanks for being a sport and fixing things that have nothing to do with your change. |
@cbezault not sure which fixes you are referring to? Unfortunately I didn't have the time to work on the fallout yet. I plan to do so because not having CMake 3.16 in Vcpkg is holding me back, but I don't know when I'll have time for it. |
/azp run |
/azp run |
Closing this PR since it seems that no progress is being made. Please reopen if work is still being done. |
This PR updates the version of the CMake instance used by Vcpkg to build packages.
What does your PR fix? Libraries that require CMake 3.15 or CMake 3.16 cannot currently be built with Vcpkg unless a custom CMake version is supplied because Vcpkg pulls an outdated version of CMake.
Which triplets are supported/not supported? Have you updated the CI baseline? does not apply
Does your PR follow the maintainer guide? yes