[xerces-c] fixed issue #9654 #9702

mitza-oci · 2020-01-15T18:40:54Z

Using first attempt and review suggestions from #9655

Describe the pull request

What does your PR fix? Fixes issue [xerces-c] https://github.com/apache/xerces-c/archive/Xerces-C_3_2_2.tar.gz no longer exist #9654
Which triplets are supported/not supported? Have you updated the CI baseline?
No change to existing xerces-c port
Does your PR follow the maintainer guide?
AFAIK

msftclas · 2020-01-15T18:41:08Z

All CLA requirements met.

NancyLi1013 · 2020-01-16T06:46:40Z

ports/xerces-c/portfile.cmake

-file(COPY ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/xerces-c)
-file(RENAME ${CURRENT_PACKAGES_DIR}/share/xerces-c/LICENSE ${CURRENT_PACKAGES_DIR}/share/xerces-c/copyright)
+# Handle copyright
+file(INSTALL ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/xerces-c RENAME copyright)


Could you please update
file(INSTALL ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/xerces-c RENAME copyright)
as
file(INSTALL ${SOURCE_PATH}/LICENSE DESTINATION ${CURRENT_PACKAGES_DIR}/share/${PORT} RENAME copyright)?

NancyLi1013 · 2020-01-16T07:00:36Z

Hi @mitza-oci thanks for this PR.
Could you also bump the version in ports/xerces-c/CONTROL file?

NancyLi1013 · 2020-01-16T07:04:41Z

Have existed PR #9655.

NancyLi1013 · 2020-01-17T01:31:49Z

It seems that there is something wrong with osx pipeline.
We will go further investigation about the regressions.

NancyLi1013 · 2020-01-17T07:10:54Z

Related #9726.

mitza-oci · 2020-01-17T14:57:30Z

It seems that there is something wrong with osx pipeline.
We will go further investigation about the regressions.

Is there anything left to do before merging this? vcpkg's xerces-c has been broken for some time and our downstream project's CI depends on it.

NancyLi1013 · 2020-01-19T03:04:59Z

xalan-c failed on osx pipeline now.
Could you please take a look and try to fix the regression caused by xalan-c?
install-x64-osx-dbg-out .log

mitza-oci · 2020-01-20T15:14:30Z

xalan-c failed on osx pipeline now.
Could you please take a look and try to fix the regression caused by xalan-c?
install-x64-osx-dbg-out .log

How is it working on master? Unless there is a cached download? xerces-c cannot be downloaded from the URL used:

-- Downloading https://github.com/apache/xerces-c/archive/Xerces-C_3_2_2.tar.gz... Failed. Status: 22;"HTTP response code said error"
CMake Error at scripts/cmake/vcpkg_download_distfile.cmake:175 (message):

      Failed to download file.

Because xerces-c has broken on master for a while, we can't determine if this failure on Apple macOS is new to this PR (shouldn't be).

NancyLi1013 · 2020-01-21T02:20:02Z

Hi @mitza-oci
Since you have changed the URL for xerces-c , it can be downloaded and installed successfully.
So where did you get the above error info?
The current regression is caused by xalan-c instead of xerces-c.
Maybe we should pay attention to xalan-c and try to fix it.

mitza-oci · 2020-01-21T15:28:26Z

Hi @mitza-oci
Since you have changed the URL for xerces-c , it can be downloaded and installed successfully.
So where did you get the above error info?

The above is for master, not my branch. When using master, xerces-c cannot be downloaded. So the CI build indicating "success" on master is not accurate -- my guess is that the CI is using a cached download.

The current regression is caused by xalan-c instead of xerces-c.
Maybe we should pay attention to xalan-c and try to fix it.

I can't reproduce the error locally and I'm not set up to use vcpkg on Apple macOS. This PR as-is restores vcpkg's xerces-c package to a useable state. Someone who knows the macOS-specific code in xalan/xerces should continue to fix any remaining errors.

This is what I see on macOS, vcpkg fails to bootstrap:

.../vcpkg/scripts/bootstrap.sh: line 219: [: Configured with: --prefix=/Applications/Xcode: integer expression expected
-- The C compiler identification is AppleClang 11.0.0.11000033
-- The CXX compiler identification is AppleClang 11.0.0.11000033
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc
-- Check for working C compiler: /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/cc -- works
-- Detecting C compiler ABI info
-- Detecting C compiler ABI info - done
-- Detecting C compile features
-- Detecting C compile features - done
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/usr/bin/g++
-- Check for working CXX compiler: /Applications/Xcode.app/Contents/Developer/usr/bin/g++ -- works
-- Detecting CXX compiler ABI info
-- Detecting CXX compiler ABI info - done
-- Detecting CXX compile features
-- Detecting CXX compile features - done
-- Looking for pthread.h
-- Looking for pthread.h - found
-- Looking for pthread_create
-- Looking for pthread_create - found
-- Found Threads: TRUE
-- Performing Test USES_LIBSTDCXX
-- Performing Test USES_LIBSTDCXX - Failed
-- Performing Test USES_LIBCXX
-- Performing Test USES_LIBCXX - Success
-- Configuring done
-- Generating done
-- Build files have been written to: .../vcpkg/toolsrc/build.rel
[0/2] Re-checking globbed directories...
[1/67] Building CXX object CMakeFiles/vcpkg.dir/src/vcpkg.cpp.o
FAILED: CMakeFiles/vcpkg.dir/src/vcpkg.cpp.o
/Applications/Xcode.app/Contents/Developer/usr/bin/g++  -DDISABLE_METRICS=0 -I../include -O3 -DNDEBUG -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.15.sdk -mmacosx-version-min=10.14   -std=c++1z -MD -MT CMakeFiles/vcpkg.dir/src/vcpkg.cpp.o -MF CMakeFiles/vcpkg.dir/src/vcpkg.cpp.o.d -o CMakeFiles/vcpkg.dir/src/vcpkg.cpp.o -c ../src/vcpkg.cpp
In file included from ../src/vcpkg.cpp:24:
../include/vcpkg/base/files.h:57:41: error: 'file_status' is unavailable: introduced in macOS 10.15
    struct file_status : private stdfs::file_status

I don't see anything in vcpkg documentation indicating the minimum macOS version required.

mitza-oci · 2020-01-21T18:50:33Z

Looks like the issue was already fixed in #9726 which made almost the exact same change to xerces-c/portfile.cmake. That one has HEAD_REF trunk which I'm not sure will work if someone tries that configuration.

NancyLi1013 · 2020-01-22T09:48:36Z

@mitza-oci
Could you please resolve conflicts about this PR?

mitza-oci · 2020-01-22T23:26:02Z

The package writes to both share/xercesc and share/xerces-c. The license file has to be in xerces-c, should the other files move there as well?

NancyLi1013 · 2020-01-23T02:18:31Z

The *.cmake files such as *target.cmake, *config.cmake should be in share/xercesc, which is decided by TARGET_PATH in vcpkg_fixup_cmake_targets(). Other files such as license, doc, usage should be in share/${PORT} (here is xercesc-c).

mitza-oci · 2020-01-23T23:25:54Z

The *.cmake files such as *target.cmake, *config.cmake should be in share/xercesc, which is decided by TARGET_PATH in vcpkg_fixup_cmake_targets(). Other files such as license, doc, usage should be in share/${PORT} (here is xercesc-c).

I'm seeing vcpkg-cmake-wrapper.cmake in xerces-c. Is that correct?

mitza-oci · 2020-01-23T23:29:46Z

I'm seeing vcpkg-cmake-wrapper.cmake in xerces-c. Is that correct?

Looks like that was a local change, which I reverted.

mitza-oci · 2020-01-24T23:08:53Z

Looks like the error in vcpkg-Linux-PR-test was not related to the change in this PR.

vicroms · 2020-01-29T01:02:13Z

You're right, I'll trigger a rebuild

mitza-oci · 2020-01-29T15:26:05Z

You're right, I'll trigger a rebuild

Thank you, looks like it worked.

mitza-oci requested a review from NancyLi1013 January 15, 2020 18:41

mitza-oci mentioned this pull request Jan 15, 2020

Integration Test cleanups OpenDDS/OpenDDS#1437

Merged

PhoebeHui assigned NancyLi1013 Jan 16, 2020

NancyLi1013 suggested changes Jan 16, 2020

View reviewed changes

mitza-oci requested a review from NancyLi1013 January 16, 2020 16:08

NancyLi1013 added the waiting for response label Jan 19, 2020

[xerces-c] fixed issue microsoft#9654 using git tag

e17def7

mitza-oci force-pushed the issue9654 branch from e425b97 to e17def7 Compare January 23, 2020 23:29

mitza-oci requested a review from JackBoosY January 27, 2020 20:15

vicroms added info:reviewed Pull Request changes follow basic guidelines and removed waiting for response labels Jan 29, 2020

vicroms merged commit b5b21df into microsoft:master Jan 29, 2020

NancyLi1013 mentioned this pull request Feb 3, 2020

[xerces-c] Change url for xerces-c and the signature #9655

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[xerces-c] fixed issue #9654 #9702

[xerces-c] fixed issue #9654 #9702

mitza-oci commented Jan 15, 2020

msftclas commented Jan 15, 2020 •

edited

Loading

NancyLi1013 Jan 16, 2020

NancyLi1013 commented Jan 16, 2020

NancyLi1013 commented Jan 16, 2020

NancyLi1013 commented Jan 17, 2020 •

edited

Loading

NancyLi1013 commented Jan 17, 2020

mitza-oci commented Jan 17, 2020

NancyLi1013 commented Jan 19, 2020

mitza-oci commented Jan 20, 2020

NancyLi1013 commented Jan 21, 2020

mitza-oci commented Jan 21, 2020

mitza-oci commented Jan 21, 2020

NancyLi1013 commented Jan 22, 2020

mitza-oci commented Jan 22, 2020

NancyLi1013 commented Jan 23, 2020

mitza-oci commented Jan 23, 2020

mitza-oci commented Jan 23, 2020

mitza-oci commented Jan 24, 2020

vicroms commented Jan 29, 2020

mitza-oci commented Jan 29, 2020

[xerces-c] fixed issue #9654 #9702

[xerces-c] fixed issue #9654 #9702

Conversation

mitza-oci commented Jan 15, 2020

msftclas commented Jan 15, 2020 • edited Loading

NancyLi1013 Jan 16, 2020

Choose a reason for hiding this comment

NancyLi1013 commented Jan 16, 2020

NancyLi1013 commented Jan 16, 2020

NancyLi1013 commented Jan 17, 2020 • edited Loading

NancyLi1013 commented Jan 17, 2020

mitza-oci commented Jan 17, 2020

NancyLi1013 commented Jan 19, 2020

mitza-oci commented Jan 20, 2020

NancyLi1013 commented Jan 21, 2020

mitza-oci commented Jan 21, 2020

mitza-oci commented Jan 21, 2020

NancyLi1013 commented Jan 22, 2020

mitza-oci commented Jan 22, 2020

NancyLi1013 commented Jan 23, 2020

mitza-oci commented Jan 23, 2020

mitza-oci commented Jan 23, 2020

mitza-oci commented Jan 24, 2020

vicroms commented Jan 29, 2020

mitza-oci commented Jan 29, 2020

msftclas commented Jan 15, 2020 •

edited

Loading

NancyLi1013 commented Jan 17, 2020 •

edited

Loading