Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cryptopp] Fixed build error on ARM32/ARM64 Windows #9633

Merged
merged 6 commits into from
Jan 22, 2020

Conversation

shibayan
Copy link
Contributor

Describe the pull request

Fixed build error on arm-uwp / arm64-uwp / arm64-windows (UWP error only VS2019)

Fixes #9530

@JackBoosY JackBoosY self-requested a review January 12, 2020 05:45
@JackBoosY JackBoosY self-assigned this Jan 12, 2020
@JackBoosY
Copy link
Contributor

/azp run

Copy link
Contributor

@JackBoosY JackBoosY left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update version in file CONTROL?
See documentation.

@JackBoosY
Copy link
Contributor

@vicroms It looks like there is something wrong with the boost library on osx, can you take a look?

@JackBoosY
Copy link
Contributor

These fake failures will resolve in #9726.

ports/cryptopp/portfile.cmake Outdated Show resolved Hide resolved
@vicroms
Copy link
Member

vicroms commented Jan 17, 2020

/azp run

@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Jan 19, 2020
@vicroms vicroms merged commit 11b8872 into microsoft:master Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cryptopp build failure on arm64-windows
3 participants