Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add customizer scope to TeachingBubbleContent #7294

Merged
merged 2 commits into from
Dec 4, 2018
Merged

Add customizer scope to TeachingBubbleContent #7294

merged 2 commits into from
Dec 4, 2018

Conversation

Vitalius1
Copy link
Contributor

@Vitalius1 Vitalius1 commented Dec 4, 2018 •
edited
Loading

Pull request checklist

  • Include a change request file using $ npm run change
    Adding a customizer scope to TeachingBubbleContent to allow pass some fluent styles through Customizer. This issue surfaced when testing Coachmark component example which is using it in its own Callout resulting in a broken fluent style for Coachmark
    screen shot 2018-12-03 at 6 54 34 pm
Microsoft Reviewers: Open in CodeFlow

@Vitalius1 Vitalius1 requested a review from mikewheaton December 4, 2018 03:01
@Vitalius1
Copy link
Contributor Author

@micahgodbolt will need your approval for it to be merged.
Also, who could explain how the className registering works in this scenario: We have TeachingBubble registering them once, and then internally it renders TeachingBubbleContent which registers them again. Are we ending up with two classNames with different hashes but with the same styles? Or I am interpreting it wrong 😄

@Vitalius1
Copy link
Contributor Author

Looks like it's doing what I assumed. The underlined clasess are just a test me applying the same class on both of them and it ends up different classNames with the same styles attached to them. Feels wrong somehow. TeachingBubble registers all of them but uses only root and later TeachingBubbleContent registers them again with different hashes and uses all except the root.
screen shot 2018-12-04 at 11 51 17 am

@Vitalius1 Vitalius1 merged commit 3deada2 into microsoft:master Dec 4, 2018
@msft-github-bot
Copy link
Contributor

🎉[email protected] has been released which incorporates this pull request.:tada:

Handy Links:

Markionium added a commit to Markionium/office-ui-fabric-react that referenced this pull request Dec 7, 2018
@Markionium
Merge branch 'master' into mapol/vertical-persona
19183d8 
* master: (55 commits)
  Applying package updates.
  default spellCheck=false in BasePicker (microsoft#7301)
  Separating border:none from .cell and removing from .root to avoid style override in DetailsColumn (microsoft#7211)
  Dropdown component honors ariaLabel prop (microsoft#7292)
  Add extensions for PowerShell, HEIC, 3gp, mak to FileTypeIconMap (microsoft#7299)
  Fix microsoft#7258 - Documentation is missing for button (microsoft#7302)
  Applying package updates.
  Add customizer scope to TeachingBubbleContent (microsoft#7294)
  Applying package updates.
  DevExp: Part 2 of 2 - the codebase no longer uses const enums, enabling consumers to be able to use isolatedModules (microsoft#7119)
  Add card dgl functionality (microsoft#7287)
  Only support LTS versions of Node 8 and 10 (microsoft#7290)
  add shift into delete action (microsoft#7274)
  Update CODEOWNERS
  Adding RTL support for DetailsList drag-drop to reorder columns (microsoft#7267)
  Applying package updates.
  Improve TeachingBubble usage docs (microsoft#7266)
  Lifting the resolution of default and user provided style variables to Utilities. (microsoft#7261)
  Re-adding animation for drag-n-drop to reorder columns (microsoft#7213)
  Update DetailsList Drag & Drop Example Snapshot (microsoft#7272)
  ...
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@micahgodbolt micahgodbolt micahgodbolt approved these changes

@mikewheaton mikewheaton mikewheaton approved these changes

Assignees

@aftab-hassan aftab-hassan

Labels
Component: TeachingBubble
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Vitalius1 @msft-github-bot @mikewheaton @micahgodbolt @aftab-hassan