Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Documentation is missing for button #7258

Closed
rfrerebe opened this issue Nov 29, 2018 · 3 comments · Fixed by #7302
Closed

Documentation is missing for button #7258

rfrerebe opened this issue Nov 29, 2018 · 3 comments · Fixed by #7302
Assignees
@aftab-hassan
Labels
Area: Documentation Type: Bug 🐛

Comments

@rfrerebe
Copy link

rfrerebe commented Nov 29, 2018 •
edited
Loading

Hello,

Wen reading documentation for Button :
https://developer.microsoft.com/en-us/fabric#/components/button

I was expecting to find documentation for IButtonProps
https://github.com/OfficeDev/office-ui-fabric-react/blob/master/packages/office-ui-fabric-react/src/components/Button/Button.types.ts#L34-L291

Basically all available props for a button, but there is only

  • IButton interface
  • ElementType enum
  • ButtonType enum
  • IButtonStyles interface

Those are interesting, but it seems that IButtonProps is the most important for button.
Is it normal ? or am i missing something ?

Thanks
@micahgodbolt
Copy link
Member

Oh yeah, that seems to be a bug!

@dzearing
Copy link
Member

@cliffkoh Is there a small issue with the processing that's causing this? There is just one Button.types.ts file which has the interface and it's not showing up after parsing.

aftab-hassan added a commit to aftab-hassan/office-ui-fabric-react that referenced this issue Dec 5, 2018
@aftab-hassan
Fix Issue:microsoft#7258 - Documentation is missing for button
aba4d11
aftab-hassan added a commit to aftab-hassan/office-ui-fabric-react that referenced this issue Dec 5, 2018
@aftab-hassan
Fix Issue:microsoft#7258 - Documentation is missing for button
07c0005
@aftab-hassan aftab-hassan mentioned this issue Dec 5, 2018
Merged
2 tasks
dzearing pushed a commit that referenced this issue Dec 5, 2018
@aftab-hassan @dzearing
Fix #7258 - Documentation is missing for button (#7302)
09f1011 
* Fix Issue:#7258 - Documentation is missing for button

* Fix Issue:#7258 - Documentation is missing for button
@msft-github-bot
Copy link
Contributor

🎉This issue was addressed in #7302, which has now been successfully released as @uifabric/[email protected].:tada:

Handy Links:

Markionium added a commit to Markionium/office-ui-fabric-react that referenced this issue Dec 7, 2018
@Markionium
Merge branch 'master' into mapol/vertical-persona
19183d8 
* master: (55 commits)
  Applying package updates.
  default spellCheck=false in BasePicker (microsoft#7301)
  Separating border:none from .cell and removing from .root to avoid style override in DetailsColumn (microsoft#7211)
  Dropdown component honors ariaLabel prop (microsoft#7292)
  Add extensions for PowerShell, HEIC, 3gp, mak to FileTypeIconMap (microsoft#7299)
  Fix microsoft#7258 - Documentation is missing for button (microsoft#7302)
  Applying package updates.
  Add customizer scope to TeachingBubbleContent (microsoft#7294)
  Applying package updates.
  DevExp: Part 2 of 2 - the codebase no longer uses const enums, enabling consumers to be able to use isolatedModules (microsoft#7119)
  Add card dgl functionality (microsoft#7287)
  Only support LTS versions of Node 8 and 10 (microsoft#7290)
  add shift into delete action (microsoft#7274)
  Update CODEOWNERS
  Adding RTL support for DetailsList drag-drop to reorder columns (microsoft#7267)
  Applying package updates.
  Improve TeachingBubble usage docs (microsoft#7266)
  Lifting the resolution of default and user provided style variables to Utilities. (microsoft#7261)
  Re-adding animation for drag-n-drop to reorder columns (microsoft#7213)
  Update DetailsList Drag & Drop Example Snapshot (microsoft#7272)
  ...
@microsoft microsoft locked as resolved and limited conversation to collaborators Aug 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@aftab-hassan aftab-hassan

Labels
Area: Documentation Type: Bug 🐛
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #7258 - Documentation is missing for button aftab-hassan/office-ui-fabric-react
5 participants
@dzearing @micahgodbolt @aftab-hassan @rfrerebe @msft-github-bot