Improve TeachingBubble usage docs #7266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bigbadcapers , would you mind taking a look as well when you have a chance? Thank you! |
...ric-react/src/components/TeachingBubble/examples/TeachingBubble.WideIllustration.Example.tsx
Show resolved
Hide resolved
KevinTCoughlin
approved these changes
Nov 30, 2018
There was a problem hiding this comment.
w/ minor suggestions. Also would be interested in @micahgodbolt signing-off.
packages/office-ui-fabric-react/src/components/TeachingBubble/docs/TeachingBubbleDonts.md
Outdated
Show resolved
Hide resolved
packages/office-ui-fabric-react/src/components/TeachingBubble/docs/TeachingBubbleDonts.md
Outdated
Show resolved
Hide resolved
packages/office-ui-fabric-react/src/components/TeachingBubble/docs/TeachingBubbleDonts.md
Outdated
Show resolved
Hide resolved
This was referenced Dec 1, 2018
|
🎉 Handy Links: |
|
@Jahnp thanks for adding me, in terms of documentation the new details looks good. With regards to the animation itself, the ask is not to make it disable-able but rather improve it because it's got weird framerate issues and slowdown issues towards the end. The original design intent is to match this bouncejs: https://goo.gl/4pm5mA |
Markionium
added a commit
to Markionium/office-ui-fabric-react
that referenced
this pull request
Dec 7, 2018
* master: (55 commits) Applying package updates. default spellCheck=false in BasePicker (microsoft#7301) Separating border:none from .cell and removing from .root to avoid style override in DetailsColumn (microsoft#7211) Dropdown component honors ariaLabel prop (microsoft#7292) Add extensions for PowerShell, HEIC, 3gp, mak to FileTypeIconMap (microsoft#7299) Fix microsoft#7258 - Documentation is missing for button (microsoft#7302) Applying package updates. Add customizer scope to TeachingBubbleContent (microsoft#7294) Applying package updates. DevExp: Part 2 of 2 - the codebase no longer uses const enums, enabling consumers to be able to use isolatedModules (microsoft#7119) Add card dgl functionality (microsoft#7287) Only support LTS versions of Node 8 and 10 (microsoft#7290) add shift into delete action (microsoft#7274) Update CODEOWNERS Adding RTL support for DetailsList drag-drop to reorder columns (microsoft#7267) Applying package updates. Improve TeachingBubble usage docs (microsoft#7266) Lifting the resolution of default and user provided style variables to Utilities. (microsoft#7261) Re-adding animation for drag-n-drop to reorder columns (microsoft#7213) Update DetailsList Drag & Drop Example Snapshot (microsoft#7272) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
$ npm run changeDescription of changes
See #7243. TeachingBubble's usage docs are woefully inadequate; this PR expands on them. It also fixes a small visual bug on one of the examples.
Microsoft Reviewers: Open in CodeFlow