-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DevExp: Part 2 of 2 - the codebase no longer uses const enums, enabling consumers to be able to use isolatedModules #7119
Conversation
A way to solve this issue without incurring increase in bytes is use Proxy's catchall: |
So this is part 2 of 2 of the NON-IconNames const enum changes. For IconNames, I'm gonna ask for a small discussion between a few groups to nail down what we will do there. This PR now just is scoped to the other smaller const enums that are remaining. |
🎉 Handy Links: |
🎉 Handy Links: |
* master: (55 commits) Applying package updates. default spellCheck=false in BasePicker (microsoft#7301) Separating border:none from .cell and removing from .root to avoid style override in DetailsColumn (microsoft#7211) Dropdown component honors ariaLabel prop (microsoft#7292) Add extensions for PowerShell, HEIC, 3gp, mak to FileTypeIconMap (microsoft#7299) Fix microsoft#7258 - Documentation is missing for button (microsoft#7302) Applying package updates. Add customizer scope to TeachingBubbleContent (microsoft#7294) Applying package updates. DevExp: Part 2 of 2 - the codebase no longer uses const enums, enabling consumers to be able to use isolatedModules (microsoft#7119) Add card dgl functionality (microsoft#7287) Only support LTS versions of Node 8 and 10 (microsoft#7290) add shift into delete action (microsoft#7274) Update CODEOWNERS Adding RTL support for DetailsList drag-drop to reorder columns (microsoft#7267) Applying package updates. Improve TeachingBubble usage docs (microsoft#7266) Lifting the resolution of default and user provided style variables to Utilities. (microsoft#7261) Re-adding animation for drag-n-drop to reorder columns (microsoft#7213) Update DetailsList Drag & Drop Example Snapshot (microsoft#7272) ...
Is there an ETA on when this will get completed to fix #7110 ? |
Pull request checklist
$ npm run change
Description of changes
We will no longer use const enum after this check in. Before we merge this, we should verify this with @KevinTCoughlin with some existing apps on size impact.
Microsoft Reviewers: Open in CodeFlow