chore: migrate to nx 16.1.4 #28583
Merged
chore: migrate to nx 16.1.4 #28583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hotell
added
Area: Build System
dependencies
📊 Bundle size report
Unchanged fixtures
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| InfoButton | mount | 18 | 16 | 5000 | Possible regression |
All results
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 618 | 621 | 5000 | |
| Button | mount | 291 | 300 | 5000 | |
| Field | mount | 1067 | 1055 | 5000 | |
| FluentProvider | mount | 669 | 640 | 5000 | |
| FluentProviderWithTheme | mount | 74 | 83 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 66 | 64 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 83 | 72 | 10 | |
| InfoButton | mount | 18 | 16 | 5000 | Possible regression |
| MakeStyles | mount | 863 | 897 | 50000 | |
| Persona | mount | 1683 | 1651 | 5000 | |
| SpinButton | mount | 1337 | 1325 | 5000 |
Perf Analysis (
|
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ImageMinimalPerf.default | 231 | 212 | 1.09:1 |
| RadioGroupMinimalPerf.default | 275 | 252 | 1.09:1 |
| AttachmentMinimalPerf.default | 90 | 83 | 1.08:1 |
| AccordionMinimalPerf.default | 81 | 76 | 1.07:1 |
| TooltipMinimalPerf.default | 1289 | 1217 | 1.06:1 |
| ChatMinimalPerf.default | 438 | 418 | 1.05:1 |
| ItemLayoutMinimalPerf.default | 729 | 695 | 1.05:1 |
| AvatarMinimalPerf.default | 110 | 106 | 1.04:1 |
| ButtonOverridesMissPerf.default | 665 | 638 | 1.04:1 |
| DropdownManyItemsPerf.default | 382 | 369 | 1.04:1 |
| SliderMinimalPerf.default | 747 | 720 | 1.04:1 |
| CustomToolbarPrototype.default | 1501 | 1448 | 1.04:1 |
| HeaderMinimalPerf.default | 201 | 195 | 1.03:1 |
| ListMinimalPerf.default | 303 | 295 | 1.03:1 |
| ListNestedPerf.default | 318 | 308 | 1.03:1 |
| StatusMinimalPerf.default | 388 | 377 | 1.03:1 |
| LayoutMinimalPerf.default | 200 | 196 | 1.02:1 |
| RosterPerf.default | 1541 | 1511 | 1.02:1 |
| PopupMinimalPerf.default | 353 | 345 | 1.02:1 |
| TextAreaMinimalPerf.default | 293 | 286 | 1.02:1 |
| ToolbarMinimalPerf.default | 532 | 522 | 1.02:1 |
| TreeWith60ListItems.default | 89 | 87 | 1.02:1 |
| DatepickerMinimalPerf.default | 3490 | 3444 | 1.01:1 |
| DropdownMinimalPerf.default | 1413 | 1395 | 1.01:1 |
| EmbedMinimalPerf.default | 1868 | 1842 | 1.01:1 |
| FormMinimalPerf.default | 222 | 219 | 1.01:1 |
| LoaderMinimalPerf.default | 186 | 185 | 1.01:1 |
| MenuButtonMinimalPerf.default | 953 | 944 | 1.01:1 |
| SplitButtonMinimalPerf.default | 2265 | 2239 | 1.01:1 |
| AnimationMinimalPerf.default | 288 | 289 | 1:1 |
| CarouselMinimalPerf.default | 257 | 258 | 1:1 |
| InputMinimalPerf.default | 543 | 543 | 1:1 |
| PortalMinimalPerf.default | 81 | 81 | 1:1 |
| ProviderMergeThemesPerf.default | 650 | 652 | 1:1 |
| ProviderMinimalPerf.default | 198 | 198 | 1:1 |
| SkeletonMinimalPerf.default | 193 | 193 | 1:1 |
| TableManyItemsPerf.default | 1110 | 1115 | 1:1 |
| VideoMinimalPerf.default | 440 | 442 | 1:1 |
| BoxMinimalPerf.default | 192 | 194 | 0.99:1 |
| CheckboxMinimalPerf.default | 1123 | 1130 | 0.99:1 |
| DialogMinimalPerf.default | 443 | 447 | 0.99:1 |
| DividerMinimalPerf.default | 204 | 206 | 0.99:1 |
| LabelMinimalPerf.default | 214 | 216 | 0.99:1 |
| ReactionMinimalPerf.default | 213 | 215 | 0.99:1 |
| IconMinimalPerf.default | 377 | 380 | 0.99:1 |
| TextMinimalPerf.default | 194 | 195 | 0.99:1 |
| ButtonSlotsPerf.default | 304 | 310 | 0.98:1 |
| ChatDuplicateMessagesPerf.default | 146 | 149 | 0.98:1 |
| ChatWithPopoverPerf.default | 190 | 194 | 0.98:1 |
| HeaderSlotsPerf.default | 467 | 476 | 0.98:1 |
| CardMinimalPerf.default | 309 | 320 | 0.97:1 |
| FlexMinimalPerf.default | 153 | 157 | 0.97:1 |
| RefMinimalPerf.default | 102 | 105 | 0.97:1 |
| ListCommonPerf.default | 373 | 387 | 0.96:1 |
| MenuMinimalPerf.default | 489 | 512 | 0.96:1 |
| TableMinimalPerf.default | 224 | 237 | 0.95:1 |
| TreeMinimalPerf.default | 455 | 478 | 0.95:1 |
| AlertMinimalPerf.default | 144 | 153 | 0.94:1 |
| AttachmentSlotsPerf.default | 616 | 655 | 0.94:1 |
| ListWith60ListItems.default | 347 | 372 | 0.93:1 |
| SegmentMinimalPerf.default | 185 | 198 | 0.93:1 |
| GridMinimalPerf.default | 179 | 194 | 0.92:1 |
| ButtonMinimalPerf.default | 90 | 106 | 0.85:1 |
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| BaseButton | mount | 622 | 629 | 5000 | |
| Breadcrumb | mount | 1666 | 1681 | 1000 | |
| Checkbox | mount | 1677 | 1707 | 5000 | |
| CheckboxBase | mount | 1474 | 1470 | 5000 | |
| ChoiceGroup | mount | 2998 | 2944 | 5000 | |
| ComboBox | mount | 680 | 659 | 1000 | |
| CommandBar | mount | 6216 | 6155 | 1000 | |
| ContextualMenu | mount | 12765 | 12735 | 1000 | |
| DefaultButton | mount | 752 | 742 | 5000 | |
| DetailsRow | mount | 2202 | 2168 | 5000 | |
| DetailsRowFast | mount | 2200 | 2147 | 5000 | |
| DetailsRowNoStyles | mount | 2033 | 2027 | 5000 | |
| Dialog | mount | 2727 | 2647 | 1000 | |
| DocumentCardTitle | mount | 211 | 225 | 1000 | |
| Dropdown | mount | 1964 | 1970 | 5000 | |
| FocusTrapZone | mount | 1126 | 1149 | 5000 | |
| FocusZone | mount | 1071 | 1059 | 5000 | |
| GroupedList | mount | 41041 | 40855 | 2 | |
| GroupedList | virtual-rerender | 19534 | 19731 | 2 | |
| GroupedList | virtual-rerender-with-unmount | 50069 | 50160 | 2 | |
| GroupedListV2 | mount | 225 | 227 | 2 | |
| GroupedListV2 | virtual-rerender | 204 | 214 | 2 | |
| GroupedListV2 | virtual-rerender-with-unmount | 227 | 231 | 2 | |
| IconButton | mount | 1101 | 1067 | 5000 | |
| Label | mount | 340 | 339 | 5000 | |
| Layer | mount | 2702 | 2703 | 5000 | |
| Link | mount | 384 | 386 | 5000 | |
| MenuButton | mount | 935 | 945 | 5000 | |
| MessageBar | mount | 21273 | 21512 | 5000 | |
| Nav | mount | 1943 | 1915 | 1000 | |
| OverflowSet | mount | 789 | 775 | 5000 | |
| Panel | mount | 1792 | 1781 | 1000 | |
| Persona | mount | 728 | 724 | 1000 | |
| Pivot | mount | 873 | 869 | 1000 | |
| PrimaryButton | mount | 836 | 832 | 5000 | |
| Rating | mount | 4647 | 4553 | 5000 | |
| SearchBox | mount | 904 | 871 | 5000 | |
| Shimmer | mount | 1910 | 1868 | 5000 | |
| Slider | mount | 1317 | 1306 | 5000 | |
| SpinButton | mount | 2846 | 2885 | 5000 | |
| Spinner | mount | 396 | 391 | 5000 | |
| SplitButton | mount | 1793 | 1870 | 5000 | |
| Stack | mount | 414 | 399 | 5000 | |
| StackWithIntrinsicChildren | mount | 887 | 847 | 5000 | |
| StackWithTextChildren | mount | 2565 | 2603 | 5000 | |
| SwatchColorPicker | mount | 6157 | 6131 | 5000 | |
| TagPicker | mount | 1417 | 1454 | 5000 | |
| Text | mount | 376 | 377 | 5000 | |
| TextField | mount | 890 | 936 | 5000 | |
| ThemeProvider | mount | 835 | 821 | 5000 | |
| ThemeProvider | virtual-rerender | 585 | 594 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 1249 | 1257 | 5000 | |
| Toggle | mount | 614 | 598 | 5000 | |
| buttonNative | mount | 180 | 190 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1d0798e:
|
🕵 fluentuiv8 No visual regressions between this PR and main |
🕵 fluentuiv9 No visual regressions between this PR and main |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: 0e9c438b78e58f346f61b15224c7b0020e4fe73e (build) |
Hotell
force-pushed
the
hotell/nx/migrate-to-16
branch
2 times, most recently
from
30471c8 to
2f824cd
Compare
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
🕵 FluentUIV0 No visual regressions between this PR and main |
…gister to make nx no-build DX work, without need to bump swc helpers to 0.5.x which increases v9 bundle size
Hotell
force-pushed
the
hotell/nx/migrate-to-16
branch
from
0bebe49 to
2dfd974
Compare
…of our generator test
…rt swc/[email protected] and remove swc-node in order to use ts-node within nx(nx uses swc/helpers 0.5 if swc-node is used/installed)
Hotell
commented
Jul 28, 2023
| @@ -20,5 +19,12 @@ | |||
| "**/node_modules", | |||
| "**/temp", | |||
| "**/*.scss.ts" | |||
| ], | |||
| "overrides": [ | |||
There was a problem hiding this comment.
added by nx migration
| @@ -45,6 +45,7 @@ | |||
| }, | |||
| "editor.rulers": [120], | |||
| "eslint.workingDirectories": [{ "mode": "auto" }], // infer working directory based on .eslintrc/package.json location | |||
| "eslint.validate": ["json"], | |||
There was a problem hiding this comment.
added by nx migration - enables to write lint rules for json as well in the future
| @@ -126,8 +126,8 @@ | |||
| "@storybook/manager-webpack5": "6.5.15", | |||
| "@storybook/react": "6.5.15", | |||
| "@storybook/theming": "6.5.15", | |||
| "@swc-node/register": "1.6.1", | |||
| "@swc/core": "1.3.30", | |||
| "@swc/cli": "0.1.62", | |||
There was a problem hiding this comment.
added by nx migration ( @nx/js uses it for transpilation )
| "@swc-node/register": "1.6.1", | ||
| "@swc/core": "1.3.30", | ||
| "@swc/cli": "0.1.62", | ||
| "@swc/core": "1.3.44", |
There was a problem hiding this comment.
last swc/core version that works with swc/helpers v0.4.x, beyond this we need to migrate all v9 packages dep to helpers 0.5
There was a problem hiding this comment.
from API and semver, swc should have bumped to 2.0 as switching to helper 0.5 its a breaking change. welp
There was a problem hiding this comment.
we should trigger an issue for this in swc
There was a problem hiding this comment.
that's definitely the right approach but it looks like that train has already left the station. ATM core latest version is 1.3.71, based on their approach I don't think they would be willing to do anything about it.
| @@ -126,8 +126,8 @@ | |||
| "@storybook/manager-webpack5": "6.5.15", | |||
| "@storybook/react": "6.5.15", | |||
| "@storybook/theming": "6.5.15", | |||
| "@swc-node/register": "1.6.1", | |||
There was a problem hiding this comment.
removing for now as swc-node is incompatible with swc/helpers 0.4 - thus making nx explode. as a fallback nx will use ts-node which is our only option for now.
ling1726
approved these changes
Jul 28, 2023
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Aug 1, 2023
* master: (37 commits) release (microsoft#28696) Fixing re-render issue for all charts when empty (microsoft#28321) feat(FluentProvider): emit errors on duplicate IDs (microsoft#28670) applying package updates fix(react-positioning): autoSize causing position update to reach maximum (microsoft#28689) fix(react-tags-preview): fix InteractionTag hover styles (microsoft#28686) Accordion: export AccordionHeaderProvider (microsoft#28542) feat(react-shared-contexts): add AnnounceContext (microsoft#28654) Added VR tests for Breadcrumb (microsoft#28653) fix(react-menu): use outline for menuItem focus ring (microsoft#28685) [Bug]: Tree, vertical spacing of branches and children is inconsistent (microsoft#28681) feaTt(react-tree): adds openItems and checkedItems to tree callback data (microsoft#28669) applying package updates Add mountNode prop to combos (microsoft#28661) react-tags-preview: add more vr test (microsoft#28582) chore: migrate to nx 16.1.4 (microsoft#28583) applying package updates chore: improves internal headless signature (microsoft#28651) fix: remove margin from icon when ToolbarButton is vertical (microsoft#28658) applying package updates ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New Behavior
@nrwlpackages are now under@nxnpm scopetoolsis now another workspace directory that hostsworkspace-plugin- a full fledged nx plugin (npm package) with all its jazzyarn nx workspace-tools <generator-name>toyarn nx g @fluentui/workspace-plugin:<generator-name>@fluentui/workspace-pluginDXvia nx Console
via terminal
discover all plugin capabilities
yarn nx list @fluentui/workspace-plugindiscover all generator options
yarn nx g @fluentui/workspace-plugin:migrate-converge-pkg --helpNOTE 💡
Related Issue(s)