chore: migrate to lerna 7 #28647

Hotell · 2023-07-26T09:39:37Z

Previous Behavior

we use 2 major versions old lerna.

it also relies on nx 15 which increases our node_modules and binaries size for no real benefit.

New Behavior

monorepo migrated to lerna 7 (v7 implementation now uses nx under the hood)
- v6 breaking changes https://github.com/lerna/lerna/blob/main/CHANGELOG.md#600-2022-10-12
- v7 breaking changes https://github.com/lerna/lerna/blob/main/CHANGELOG.md#700-2023-06-08
cleanup of node_modules exposed type issues within v8 packages
- because jest types leak to implementation (known fact) and v8 packages doenst uses skipLibCheck, when we build jest types would fail the task because under the hood types need ES2015.Iterable types
  - to fix this, those problematic packages have now updated lib

Related Issue(s)

Follows chore: migrate to nx 16.1.4 #28583

fabricteam · 2023-07-26T09:45:48Z

🕵 fluentuiv8 No visual regressions between this PR and main

codesandbox-ci · 2023-07-26T09:51:38Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit bb49a56:

Sandbox	Source
@fluentui/react 8 starter	Configuration
@fluentui/react-components 9 starter	Configuration

fabricteam · 2023-07-26T09:55:15Z

📊 Bundle size report

Unchanged fixtures

Package & Exports	Size (minified/GZIP)
`global-context` createContext	`510 B` `330 B`
`global-context` createContextSelector	`537 B` `342 B`
`priority-overflow` createOverflowManager	`4.162 kB` `1.735 kB`
`react-accordion` Accordion (including children components)	`91.932 kB` `28.052 kB`
`react-alert` Alert	`84.006 kB` `23.008 kB`
`react-avatar` Avatar	`49.384 kB` `15.546 kB`
`react-avatar` AvatarGroup	`18.782 kB` `7.48 kB`
`react-avatar` AvatarGroupItem	`64.036 kB` `19.896 kB`
`react-badge` Badge	`25.987 kB` `8.384 kB`
`react-badge` CounterBadge	`26.888 kB` `8.687 kB`
`react-badge` PresenceBadge	`24.393 kB` `8.893 kB`
`react-button` Button	`39.667 kB` `10.794 kB`
`react-button` CompoundButton	`47.023 kB` `12.295 kB`
`react-button` MenuButton	`44.466 kB` `12.188 kB`
`react-button` SplitButton	`52.469 kB` `13.771 kB`
`react-button` ToggleButton	`56.756 kB` `12.702 kB`
`react-card` Card - All	`91.443 kB` `26.437 kB`
`react-card` Card	`86.232 kB` `24.895 kB`
`react-card` CardFooter	`12.14 kB` `5.061 kB`
`react-card` CardHeader	`14.431 kB` `5.832 kB`
`react-card` CardPreview	`13.097 kB` `5.434 kB`
`react-checkbox` Checkbox	`36.155 kB` `11.925 kB`
`react-combobox` Combobox (including child components)	`90.949 kB` `29.689 kB`
`react-combobox` Dropdown (including child components)	`89.28 kB` `29.328 kB`
`react-components` react-components: Button, FluentProvider & webLightTheme	`69.572 kB` `19.658 kB`
`react-components` react-components: Accordion, Button, FluentProvider, Image, Menu, Popover	`208.688 kB` `59.552 kB`
`react-components` react-components: FluentProvider & webLightTheme	`40.966 kB` `13.569 kB`
`react-datepicker-compat` DatePicker Compat	`211.988 kB` `58.971 kB`
`react-dialog` Dialog (including children components)	`90.474 kB` `27.605 kB`
`react-divider` Divider	`19.902 kB` `7.415 kB`
`react-field` Field	`21.61 kB` `8.259 kB`
`react-image` Image	`14.818 kB` `5.902 kB`
`react-infobutton` InfoButton	`130.15 kB` `40.884 kB`
`react-infobutton` InfoLabel	`133.883 kB` `42.068 kB`
`react-input` Input	`26.143 kB` `8.844 kB`
`react-jsx-runtime` Classic Pragma	`1.072 kB` `544 B`
`react-jsx-runtime` JSX Dev Runtime	`2.893 kB` `1.319 kB`
`react-jsx-runtime` JSX Runtime	`3.479 kB` `1.554 kB`
`react-label` Label	`13.225 kB` `5.438 kB`
`react-link` Link	`16.095 kB` `6.53 kB`
`react-menu` Menu (including children components)	`140.184 kB` `43.176 kB`
`react-menu` Menu (including selectable components)	`142.92 kB` `43.714 kB`
`react-overflow` hooks only	`12.594 kB` `4.702 kB`
`react-persona` Persona	`56.275 kB` `17.425 kB`
`react-popover` Popover	`118.895 kB` `37.406 kB`
`react-portal` Portal	`12.362 kB` `4.543 kB`
`react-portal-compat` PortalCompatProvider	`6.541 kB` `2.227 kB`
`react-positioning` usePositioning	`25.245 kB` `9.141 kB`
`react-progress` ProgressBar	`16.598 kB` `6.608 kB`
`react-provider` FluentProvider	`21.511 kB` `7.994 kB`
`react-radio` Radio	`29.883 kB` `9.851 kB`
`react-radio` RadioGroup	`14.543 kB` `5.985 kB`
`react-select` Select	`27.865 kB` `9.922 kB`
`react-slider` Slider	`37.043 kB` `12.203 kB`
`react-spinbutton` SpinButton	`36.072 kB` `11.521 kB`
`react-spinner` Spinner	`22.481 kB` `8.146 kB`
`react-switch` Switch	`32.426 kB` `10.517 kB`
`react-table` DataGrid	`157.087 kB` `43.832 kB`
`react-table` Table (Primitives only)	`43.017 kB` `13.414 kB`
`react-table` Table as DataGrid	`129.841 kB` `34.929 kB`
`react-table` Table (Selection only)	`75.114 kB` `20.231 kB`
`react-table` Table (Sort only)	`73.745 kB` `19.826 kB`
`react-tags-preview` InteractionTag	`14.23 kB` `5.723 kB`
`react-tags-preview` Tag	`30.349 kB` `9.798 kB`
`react-tags-preview` TagGroup	`72.851 kB` `21.693 kB`
`react-text` Text - Default	`15.832 kB` `6.254 kB`
`react-text` Text - Wrappers	`19.01 kB` `6.578 kB`
`react-textarea` Textarea	`30.203 kB` `10.199 kB`
`react-theme` Single theme token import	`69 B` `89 B`
`react-theme` Teams: all themes	`34.611 kB` `7.295 kB`
`react-theme` Teams: Light theme	`19.282 kB` `5.486 kB`
`react-toast` Toast (including Toaster)	`91.789 kB` `27.423 kB`
`react-tooltip` Tooltip	`51.348 kB` `18.113 kB`
`react-utilities` SSRProvider	`180 B` `159 B`

_{🤖 This report was generated against 4942c5f07e08f1061cc8a6b753cd668b05482151}

fabricteam · 2023-07-26T09:57:55Z

🕵 FluentUIV0 No visual regressions between this PR and main

fabricteam · 2023-07-26T09:59:12Z

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam · 2023-07-28T11:11:09Z

Perf Analysis (`@fluentui/react-components`)

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
InfoButton	mount	15	14	5000	Possible regression

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations	Status
Avatar	mount	642	642	5000
Button	mount	336	324	5000
Field	mount	1082	1165	5000
FluentProvider	mount	682	720	5000
FluentProviderWithTheme	mount	103	103	10
FluentProviderWithTheme	virtual-rerender	105	105	10
FluentProviderWithTheme	virtual-rerender-with-unmount	74	78	10
InfoButton	mount	15	14	5000	Possible regression
MakeStyles	mount	880	858	50000
Persona	mount	1853	1785	5000
SpinButton	mount	1401	1359	5000

fabricteam · 2023-07-28T11:15:57Z

Perf Analysis (`@fluentui/react-northstar`)

⚠️ 1 potential perf regressions detected

Potential regressions comparing to master

Scenario	Current PR Ticks	Baseline Ticks	Ratio	Regression Analysis
AttachmentMinimalPerf.default	82	77	1.06:1	analysis

Perf tests with no regressions

Scenario	Current PR Ticks	Baseline Ticks	Ratio
TreeWith60ListItems.default	99	87	1.14:1
CardMinimalPerf.default	332	293	1.13:1
FlexMinimalPerf.default	168	151	1.11:1
AlertMinimalPerf.default	165	155	1.06:1
BoxMinimalPerf.default	201	190	1.06:1
LayoutMinimalPerf.default	203	192	1.06:1
PortalMinimalPerf.default	89	84	1.06:1
ProviderMinimalPerf.default	206	194	1.06:1
StatusMinimalPerf.default	402	380	1.06:1
MenuMinimalPerf.default	506	484	1.05:1
TreeMinimalPerf.default	487	470	1.04:1
ButtonOverridesMissPerf.default	665	646	1.03:1
CarouselMinimalPerf.default	270	261	1.03:1
GridMinimalPerf.default	188	182	1.03:1
InputMinimalPerf.default	553	535	1.03:1
LabelMinimalPerf.default	223	217	1.03:1
ListMinimalPerf.default	315	306	1.03:1
PopupMinimalPerf.default	356	347	1.03:1
IconMinimalPerf.default	399	388	1.03:1
TableManyItemsPerf.default	1123	1090	1.03:1
CustomToolbarPrototype.default	1511	1472	1.03:1
AnimationMinimalPerf.default	302	297	1.02:1
AvatarMinimalPerf.default	106	104	1.02:1
LoaderMinimalPerf.default	194	191	1.02:1
MenuButtonMinimalPerf.default	953	938	1.02:1
SegmentMinimalPerf.default	192	188	1.02:1
SplitButtonMinimalPerf.default	2283	2248	1.02:1
TableMinimalPerf.default	225	221	1.02:1
ToolbarMinimalPerf.default	528	517	1.02:1
ChatMinimalPerf.default	433	430	1.01:1
DividerMinimalPerf.default	206	203	1.01:1
DropdownManyItemsPerf.default	401	399	1.01:1
FormMinimalPerf.default	214	211	1.01:1
HeaderMinimalPerf.default	203	200	1.01:1
ImageMinimalPerf.default	221	218	1.01:1
ListNestedPerf.default	332	328	1.01:1
ListWith60ListItems.default	378	373	1.01:1
ProviderMergeThemesPerf.default	643	634	1.01:1
RadioGroupMinimalPerf.default	257	254	1.01:1
RefMinimalPerf.default	109	108	1.01:1
SkeletonMinimalPerf.default	195	193	1.01:1
SliderMinimalPerf.default	744	735	1.01:1
AttachmentSlotsPerf.default	647	650	1:1
ButtonMinimalPerf.default	87	87	1:1
DialogMinimalPerf.default	440	441	1:1
DropdownMinimalPerf.default	1451	1450	1:1
ListCommonPerf.default	386	386	1:1
ReactionMinimalPerf.default	203	204	1:1
TooltipMinimalPerf.default	1260	1259	1:1
CheckboxMinimalPerf.default	1120	1132	0.99:1
ItemLayoutMinimalPerf.default	692	697	0.99:1
DatepickerMinimalPerf.default	3700	3776	0.98:1
EmbedMinimalPerf.default	1820	1853	0.98:1
RosterPerf.default	1514	1551	0.98:1
TextMinimalPerf.default	183	186	0.98:1
TextAreaMinimalPerf.default	285	292	0.98:1
ChatDuplicateMessagesPerf.default	147	151	0.97:1
HeaderSlotsPerf.default	442	460	0.96:1
VideoMinimalPerf.default	424	440	0.96:1
ChatWithPopoverPerf.default	180	192	0.94:1
ButtonSlotsPerf.default	289	322	0.9:1
AccordionMinimalPerf.default	73	87	0.84:1

fabricteam · 2023-07-28T11:26:37Z

Perf Analysis (`@fluentui/react`)

No significant results to display.

All results

Scenario	Render type	Master Ticks	PR Ticks	Iterations
BaseButton	mount	613	630	5000
Breadcrumb	mount	1667	1644	1000
Checkbox	mount	1682	1657	5000
CheckboxBase	mount	1460	1475	5000
ChoiceGroup	mount	2903	2987	5000
ComboBox	mount	656	658	1000
CommandBar	mount	6149	6110	1000
ContextualMenu	mount	11983	12024	1000
DefaultButton	mount	760	735	5000
DetailsRow	mount	2172	2190	5000
DetailsRowFast	mount	2142	2175	5000
DetailsRowNoStyles	mount	1977	2018	5000
Dialog	mount	2581	2591	1000
DocumentCardTitle	mount	213	226	1000
Dropdown	mount	1987	1966	5000
FocusTrapZone	mount	1113	1111	5000
FocusZone	mount	1049	1065	5000
GroupedList	mount	40648	41133	2
GroupedList	virtual-rerender	19607	19637	2
GroupedList	virtual-rerender-with-unmount	49801	50059	2
GroupedListV2	mount	225	223	2
GroupedListV2	virtual-rerender	212	210	2
GroupedListV2	virtual-rerender-with-unmount	224	231	2
IconButton	mount	1107	1076	5000
Label	mount	327	342	5000
Layer	mount	2718	2694	5000
Link	mount	391	378	5000
MenuButton	mount	927	923	5000
MessageBar	mount	21420	21153	5000
Nav	mount	1922	1886	1000
OverflowSet	mount	781	782	5000
Panel	mount	1770	1775	1000
Persona	mount	701	732	1000
Pivot	mount	865	857	1000
PrimaryButton	mount	841	831	5000
Rating	mount	4504	4651	5000
SearchBox	mount	921	902	5000
Shimmer	mount	1819	1853	5000
Slider	mount	1333	1317	5000
SpinButton	mount	2807	2783	5000
Spinner	mount	374	387	5000
SplitButton	mount	1828	1800	5000
Stack	mount	406	403	5000
StackWithIntrinsicChildren	mount	837	851	5000
StackWithTextChildren	mount	2590	2530	5000
SwatchColorPicker	mount	5996	6025	5000
TagPicker	mount	1425	1455	5000
Text	mount	363	361	5000
TextField	mount	924	945	5000
ThemeProvider	mount	827	823	5000
ThemeProvider	virtual-rerender	574	575	5000
ThemeProvider	virtual-rerender-with-unmount	1241	1274	5000
Toggle	mount	620	615	5000
buttonNative	mount	188	184	5000

size-auditor · 2023-07-28T14:10:42Z

Asset size changes

Size Auditor did not detect a change in bundle size for any component!

Baseline commit: 4942c5f07e08f1061cc8a6b753cd668b05482151 (build)

github-actions bot added this to the July Project Cycle Q3 2023 milestone Jul 26, 2023

Hotell changed the title ~~Hotell/nx/migrate to lerna 7~~ chore: migrate to lerna 7 Jul 26, 2023

Hotell force-pushed the hotell/nx/migrate-to-lerna-7 branch from 634662d to 424ce6a Compare July 28, 2023 11:01

Hotell force-pushed the hotell/nx/migrate-to-lerna-7 branch from 424ce6a to 622f371 Compare July 28, 2023 11:30

Hotell added Area: Build System dependencies Pull requests that update a dependency file labels Jul 28, 2023

Hotell marked this pull request as ready for review July 31, 2023 14:36

Hotell requested a review from a team as a code owner July 31, 2023 14:36

TristanWatanabe approved these changes Jul 31, 2023

View reviewed changes

Hotell added 4 commits September 25, 2023 10:23

chore: migrate to lerna v6

6016942

chore: migrate to lerna v7

256a271

chore: add ES2015.Iterable to tsconfig lib as jest types need it

8ecfcce

generate change-files

bb49a56

Hotell force-pushed the hotell/nx/migrate-to-lerna-7 branch from 6884709 to bb49a56 Compare September 25, 2023 08:25

github-actions bot modified the milestones: July Project Cycle Q3 2023, September Project Cycle Q4 2023 Sep 25, 2023

Hotell merged commit ccc380c into microsoft:master Sep 25, 2023
23 checks passed

Hotell deleted the hotell/nx/migrate-to-lerna-7 branch September 25, 2023 10:49

Hotell mentioned this pull request Sep 25, 2023

[Feature]: replace @lerna/project,package-graph with nx graph resolution #29271

Closed

1 task

This was referenced Dec 28, 2023

feat: replace lerna-alias with nx APIs #30149

Merged

feat(scripts-monorepo): replace lerna/utils with pure nx apis #30178

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

chore: migrate to lerna 7 #28647

chore: migrate to lerna 7 #28647

Hotell commented Jul 26, 2023 •

edited

Loading

fabricteam commented Jul 26, 2023 •

edited

Loading

codesandbox-ci bot commented Jul 26, 2023 •

edited

Loading

fabricteam commented Jul 26, 2023 •

edited

Loading

fabricteam commented Jul 26, 2023 •

edited

Loading

fabricteam commented Jul 26, 2023 •

edited

Loading

fabricteam commented Jul 28, 2023 •

edited

Loading

fabricteam commented Jul 28, 2023 •

edited

Loading

fabricteam commented Jul 28, 2023 •

edited

Loading

size-auditor bot commented Jul 28, 2023 •

edited

Loading

chore: migrate to lerna 7 #28647

chore: migrate to lerna 7 #28647

Conversation

Hotell commented Jul 26, 2023 • edited Loading

Previous Behavior

New Behavior

Related Issue(s)

fabricteam commented Jul 26, 2023 • edited Loading

🕵 fluentuiv8 No visual regressions between this PR and main

codesandbox-ci bot commented Jul 26, 2023 • edited Loading

fabricteam commented Jul 26, 2023 • edited Loading

📊 Bundle size report

fabricteam commented Jul 26, 2023 • edited Loading

🕵 FluentUIV0 No visual regressions between this PR and main

fabricteam commented Jul 26, 2023 • edited Loading

🕵 fluentuiv9 No visual regressions between this PR and main

fabricteam commented Jul 28, 2023 • edited Loading

Perf Analysis (@fluentui/react-components)

fabricteam commented Jul 28, 2023 • edited Loading

Perf Analysis (@fluentui/react-northstar)

Potential regressions comparing to master

fabricteam commented Jul 28, 2023 • edited Loading

Perf Analysis (@fluentui/react)

size-auditor bot commented Jul 28, 2023 • edited Loading

Asset size changes

Hotell commented Jul 26, 2023 •

edited

Loading

fabricteam commented Jul 26, 2023 •

edited

Loading

codesandbox-ci bot commented Jul 26, 2023 •

edited

Loading

fabricteam commented Jul 26, 2023 •

edited

Loading

fabricteam commented Jul 26, 2023 •

edited

Loading

fabricteam commented Jul 26, 2023 •

edited

Loading

fabricteam commented Jul 28, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-components`)

fabricteam commented Jul 28, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react-northstar`)

fabricteam commented Jul 28, 2023 •

edited

Loading

Perf Analysis (`@fluentui/react`)

size-auditor bot commented Jul 28, 2023 •

edited

Loading