Add mountNode prop to combos #28661
Merged
Add mountNode prop to combos #28661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GeoffCoxMSFT
commented
Jul 27, 2023
packages/react-components/react-combobox/src/components/Combobox/renderCombobox.tsx
Outdated
Show resolved
Hide resolved
GeoffCoxMSFT
commented
Jul 27, 2023
packages/react-components/react-combobox/src/components/Dropdown/renderDropdown.tsx
Outdated
Show resolved
Hide resolved
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 599 | 604 | 5000 | |
| Button | mount | 291 | 289 | 5000 | |
| Field | mount | 1061 | 1043 | 5000 | |
| FluentProvider | mount | 630 | 654 | 5000 | |
| FluentProviderWithTheme | mount | 76 | 78 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 67 | 66 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 66 | 76 | 10 | |
| InfoButton | mount | 11 | 13 | 5000 | |
| MakeStyles | mount | 860 | 847 | 50000 | |
| Persona | mount | 1667 | 1578 | 5000 | |
| SpinButton | mount | 1367 | 1327 | 5000 |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit c0726d2:
|
📊 Bundle size report
Unchanged fixtures
|
🕵 fluentuiv9 No visual regressions between this PR and main |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: bdbf3ae799e368080db7af64f385f5c35c4c8fdf (build) |
smhigley
reviewed
Jul 27, 2023
packages/react-components/react-combobox/src/components/Combobox/useCombobox.tsx
Outdated
Show resolved
Hide resolved
packages/react-components/react-combobox/src/components/Combobox/Combobox.types.ts
Outdated
Show resolved
Hide resolved
|
Can we be consistent with other components and expose |
smhigley
approved these changes
Jul 28, 2023
That was my original plan, then others suggested making it a slot. LOL. I will update to follow the precedent. |
marcosmoura
added a commit
to marcosmoura/fluentui
that referenced
this pull request
Aug 1, 2023
* master: (37 commits) release (microsoft#28696) Fixing re-render issue for all charts when empty (microsoft#28321) feat(FluentProvider): emit errors on duplicate IDs (microsoft#28670) applying package updates fix(react-positioning): autoSize causing position update to reach maximum (microsoft#28689) fix(react-tags-preview): fix InteractionTag hover styles (microsoft#28686) Accordion: export AccordionHeaderProvider (microsoft#28542) feat(react-shared-contexts): add AnnounceContext (microsoft#28654) Added VR tests for Breadcrumb (microsoft#28653) fix(react-menu): use outline for menuItem focus ring (microsoft#28685) [Bug]: Tree, vertical spacing of branches and children is inconsistent (microsoft#28681) feaTt(react-tree): adds openItems and checkedItems to tree callback data (microsoft#28669) applying package updates Add mountNode prop to combos (microsoft#28661) react-tags-preview: add more vr test (microsoft#28582) chore: migrate to nx 16.1.4 (microsoft#28583) applying package updates chore: improves internal headless signature (microsoft#28651) fix: remove margin from icon when ToolbarButton is vertical (microsoft#28658) applying package updates ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
Allows callers to change the mountNode of the portal used to display the dropdown part for ComboBox and Dropdown.
Fixes #28625
Changes
I created a storybook example to demonstrate it working. I don't think this makes a good story to check in for combobox though.
Combobox.mount.node.mov